Handle type error constructing input

kylekatarnls · kylekatarnls · commit 3e32f657f5ae · 2023-07-17T17:53:05.000+02:00
diff --git a/src/Symfony/Component/Serializer/Normalizer/AbstractNormalizer.php b/src/Symfony/Component/Serializer/Normalizer/AbstractNormalizer.php
@@ -425,6 +425,28 @@ protected function instantiateObject(array &$data, string $class, array &$contex
                     throw $e;
                 }
 
+                $message = $e->getMessage();
+
+                if (preg_match('/#\d+ \(\$([^)]+)\) must be of type ([^,]+), ([^,]+) given/', $message, $match)) {
+                    $message = sprintf(
+                        'The type of the "%s" parameter for class "%s" must be of type "%s" ("%s" given).',
+                        $match[1],
+                        $class,
+                        $match[2],
+                        $match[3],
+                    );
+                }
+
+                $exception = NotNormalizableValueException::createForUnexpectedDataType(
+                    $message,
+                    $data,
+                    [$class],
+                    $context['deserialization_path'] ?? null,
+                    true,
+                    previous: $e,
+                );
+                $context['not_normalizable_value_exceptions'][] = $exception;
+
                 return $reflectionClass->newInstanceWithoutConstructor();
             }
         }
diff --git a/src/Symfony/Component/Serializer/Tests/SerializerTest.php b/src/Symfony/Component/Serializer/Tests/SerializerTest.php
@@ -1021,6 +1021,15 @@ public function testCollectDenormalizationErrors(?ClassMetadataFactory $classMet
                 'useMessageForUser' => false,
                 'message' => 'The type of the "something" attribute for class "Symfony\Component\Serializer\Tests\Fixtures\Php74FullWithTypedConstructor" must be one of "float" ("string" given).',
             ],
+            [
+                'currentType' => 'array',
+                'expectedTypes' => [
+                    'Symfony\Component\Serializer\Tests\Fixtures\Php74FullWithTypedConstructor',
+                ],
+                'path' => 'php74FullWithTypedConstructor',
+                'useMessageForUser' => true,
+                'message' => 'The type of the "something" parameter for class "Symfony\Component\Serializer\Tests\Fixtures\Php74FullWithTypedConstructor" must be of type "float" ("string" given).',
+            ],
             $classMetadataFactory ?
                 [
                     'currentType' => 'null',
