[DoctrineBridge] Remove deprecated classes and ContainerAwareEventManager::getListeners() deprecation
#50575
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
derrabus
requested changes
Jun 7, 2023
src/Symfony/Bridge/Doctrine/Tests/ContainerAwareEventManagerTest.php
Outdated
Show resolved
Hide resolved
38e4143 to
db7df29
Compare
derrabus
reviewed
Jun 7, 2023
stof
reviewed
Jun 7, 2023
db7df29 to
9c44816
Compare
derrabus
requested changes
Jun 7, 2023
9c44816 to
a97b1f2
Compare
stof
requested changes
Jun 7, 2023
src/Symfony/Bridge/Doctrine/Tests/ContainerAwareEventManagerTest.php
Outdated
Show resolved
Hide resolved
1de5b05 to
947912b
Compare
stof
reviewed
Jun 7, 2023
947912b to
9ce38fe
Compare
derrabus
requested changes
Jun 8, 2023
9ce38fe to
3c9c2b7
Compare
derrabus
approved these changes
Jun 8, 2023
nicolas-grekas
added a commit
that referenced
this pull request
Jun 8, 2023
…eEventManager` (alexandre-daubois) This PR was merged into the 6.3 branch. Discussion ---------- [DoctrineBridge] Remove (wrong) PHPDoc on `ContainerAwareEventManager` | Q | A | ------------- | --- | Branch? | 6.3 | Bug fix? | yes | New feature? | no | Deprecations? | no | Tickets | - | License | MIT | Doc PR | - This PR is a follow-up of the following discussion: #50575 (comment) Commits ------- d65db40 [DoctrineBridge] Remove (wrong) PHPDoc on `ContainerAwareEventManager`
symfony-splitter
pushed a commit
to symfony/doctrine-bridge
that referenced
this pull request
Jun 8, 2023
…eEventManager` (alexandre-daubois) This PR was merged into the 6.3 branch. Discussion ---------- [DoctrineBridge] Remove (wrong) PHPDoc on `ContainerAwareEventManager` | Q | A | ------------- | --- | Branch? | 6.3 | Bug fix? | yes | New feature? | no | Deprecations? | no | Tickets | - | License | MIT | Doc PR | - This PR is a follow-up of the following discussion: symfony/symfony#50575 (comment) Commits ------- d65db4073b [DoctrineBridge] Remove (wrong) PHPDoc on `ContainerAwareEventManager`
|
(rebase needed) |
3c9c2b7 to
c839f87
Compare
|
Rebased and updated with |
c839f87 to
4f3337d
Compare
|
FYI: DbalLogger is removed by #50571 already. But I'm fine either way, let's keep the change here and finish your PR first. |
derrabus
reviewed
Jun 9, 2023
|
You need to adjust the expected-missing-return-types.diff file. You can borrow the necessary change from #50571. |
derrabus
reviewed
Jun 9, 2023
5 tasks
4f3337d to
929e64d
Compare
…nager::getListeners()` deprecation
929e64d to
746b123
Compare
|
Thank you @alexandre-daubois. |
|
@derrabus to avoid having to regenerate the expected-missing-return-types.diff file all the time in those code removal PRs, maybe we should first add those return types in 7.0 (by applying the patch defined in this diff file) |
|
That's probably a good idea. |
fabpot
added a commit
that referenced
this pull request
Jun 9, 2023
This PR was merged into the 7.0 branch. Discussion ---------- [DoctrineBridge] Kill DBAL 2 support | Q | A | ------------- | --- | Branch? | 7.0 | Bug fix? | no | New feature? | yes | Deprecations? | no | Tickets | N/A | License | MIT | Doc PR | N/A DBAL 2 is dead and buried. Let's remove code that we needed to maintain DBAL 2. TODO: - [x] Deprecation layer for removed classes - [x] Check changes for possible backports to 5.4/6.4 - [x] #50576 - [x] #50579 - [x] #50575 Commits ------- eacfedf Kill DBAL 2 support
nicolas-grekas
added a commit
that referenced
this pull request
Jun 30, 2023
…here it is not used (GromNaN) This PR was merged into the 7.0 branch. Discussion ---------- [Doctrine][Serializer] Remove `ExpectDeprecationTrait` where it is not used | Q | A | ------------- | --- | Branch? | 7.0 | Bug fix? | no | New feature? | no | Deprecations? | no | Tickets | - | License | MIT | Doc PR | n/a This unused code has been left by #50558 and #50575. I think PHPStan should detect when the trait is imported but the method `expectDeprecation` is not used. Other PR for 6.4 #50828 Commits ------- 81972d3 Remove ExpectDeprecationTrait where it is not used
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Removes deprecated code introduced in #49610