8000 [DoctrineBridge] Remove deprecated classes and `ContainerAwareEventMa… · symfony/symfony@38e4143 · GitHub
[go: up one dir, main page]
Skip to content

Commit 38e4143

Browse files
alexandre-dauboisalexandre-daubois
committed
[DoctrineBridge] Remove deprecated classes and ContainerAwareEventManager::getListeners() deprecation
1 parent f0a5f45 commit 38e4143
Original file line numberDiff line numberDiff line change
@@ -5,6 +5,14 @@ Symfony 6.4 and Symfony 7.0 will be released simultaneously at the end of Novemb
55
release process, both versions will have the same features, but Symfony 7.0 won't include any deprecated features.
66
To upgrade, make sure to resolve all deprecation notices.
77

8+
Doctrine
9+
--------
10+
11+
* Removed `DoctrineDbalCacheAdapterSchemaSubscriber`, use `DoctrineDbalCacheAdapterSchemaListener` instead
12+
* Removed `MessengerTransportDoctrineSchemaSubscriber`, use `MessengerTransportDoctrineSchemaListener` instead
13+
* Removed `RememberMeTokenProviderDoctrineSchemaSubscriber`, use `RememberMeTokenProviderDoctrineSchemaListener` instead
14+
* `ContainerAwareEventManager::getListeners()` must be called with an event name
15+
816
Serializer
917
----------
1018

Original file line numberDiff line numberDiff line change
@@ -1,6 +1,12 @@
11
CHANGELOG
22
=========
33

4+
7.0
5+
---
6+
7+
* Remove `DoctrineDbalCacheAdapterSchemaSubscriber`, `MessengerTransportDoctrineSchemaSubscriber` and `RememberMeTokenProviderDoctrineSchemaSubscriber`
8+
* `ContainerAwareEventManager::getListeners()` must be called with an event name
9+
410
6.3
511
---
612

Original file line numberDiff line numberDiff line change
@@ -69,10 +69,9 @@ public function dispatchEvent($eventName, EventArgs $eventArgs = null): void
6969
public function getListeners($event = null): array
7070
{
7171
if (null === $event) {
72-
trigger_deprecation('symfony/doctrine-bridge', '6.2', 'Calling "%s()" without an event name is deprecated. Call "getAllListeners()" instead.', __METHOD__);
73-
74-
return $this->getAllListeners();
72+
throw new \InvalidArgumentException(sprintf('"%s()" must be called with an event name.', __METHOD__));
7573
}
74+
7675
if (!$this->initializedSubscribers) {
7776
$this->initializeSubscribers();
7877
}
Original file line numberDiff line numberDiff line change
@@ -245,16 +245,14 @@ public function testGetListenersForEventWhenSubscribersArePresent()
245245
$this->assertSame([$subscriber1, $listener1, $listener2], array_values($this->evm->getListeners('foo')));
246246
}
247247

248-
/**
249-
* @group legacy
250-
*/
251248
public function testGetListeners()
252249
{
< 8000 /td>
253250
$this->container->set('lazy', $listener1 = new MyListener());
254251
$this->evm->addEventListener('foo', 'lazy');
255252
$this->evm->addEventListener('foo', $listener2 = new MyListener());
256253

257-
$this->expectDeprecation('Since symfony/doctrine-bridge 6.2: Calling "Symfony\Bridge\Doctrine\ContainerAwareEventManager::getListeners()" without an event name is deprecated. Call "getAllListeners()" instead.');
254+
$this->expectExceptionMessage('"Symfony\Bridge\Doctrine\ContainerAwareEventManager::getListeners()" must be called with an event name.');
255+
$this->expectException(\InvalidArgumentException::class);
258256

259257
$this->assertSame([$listener1, $listener2], array_values($this->evm->getListeners()['foo']));
260258
}