8000 [HttpKernel][VarDumper] Fix dumping with labels by nicolas-grekas · Pull Request #50397 · symfony/symfony · GitHub
[go: up one dir, main page]
Skip to content

[HttpKernel][VarDumper] Fix dumping with labels #50397

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
May 25, 2023
Merged

[HttpKernel][VarDumper] Fix dumping with labels #50397

merged 1 commit into from
May 25, 2023

Conversation

nicolas-grekas
Copy link
Member
Q A
Branch? 6.3
Bug fix? yes
New feature? no
Deprecations? no
Tickets -
License MIT
Doc PR -

Should fix #50347 (comment) /cc @bobthecow

Also improves the display in the WDT:

image

image

@carsonbot carsonbot added this to the 6.3 milestone May 23, 2023
@carsonbot carsonbot changed the title [VarDumper][HttpKernel] Fix dumping with labels [HttpKernel][VarDumper] Fix dumping with labels May 23, 2023
@nicolas-grekas nicolas-grekas added the ❄️ Feature Freeze Important Pull Requests to finish before the next Symfony "feature freeze" label May 23, 2023
@bobthecow
Copy link
Contributor

Thanks for jumping on this, @nicolas-grekas!

This fix works, in that it no longer breaks functionality. But it does look like it introduces a change in formatted output that puts empty spans in front of a lot of things:

Screenshot 2023-05-23 at 10 19 29 AM

Either that or this was introduced somewhere else but masked by the BC break in my tests.

@nicolas-grekas nicolas-grekas removed the ❄️ Feature Freeze Important Pull Requests to finish before the next Symfony "feature freeze" label May 23, 2023
@nicolas-grekas nicolas-grekas changed the base branch from 6.4 to 6.3 May 23, 2023 16:47
@nicolas-grekas
Copy link
Member Author

@bobthecow fixed!

@nicolas-grekas nicolas-grekas merged commit 2f3e24a into symfony:6.3 May 25, 2023
@nicolas-grekas nicolas-grekas deleted the dump-fix branch May 25, 2023 13:15
@bobthecow
Copy link
Contributor

@nicolas-grekas perfect, thanks so much!

@fabpot fabpot mentioned this pull request May 27, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@stof stof stof approved these changes

@fancyweb fancyweb fancyweb approved these changes

Assignees
No one assigned
Labels
Bug HttpKernel Status: Reviewed VarDumper
Projects
None yet
Milestone
6.3
Development

Successfully merging this pull request may close these issues.
5 participants
@nicolas-grekas @bobthecow @stof @fancyweb @carsonbot
0