[DebugBundle][VarDumper] Fix dump labels compatibility #50347
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
can you please confirm that the label is a link to the source? |
|
DebugBundle behavior is to have links on the file (FooAction) not on the label. But wait I've found one more problem and I'm crafting a better patch. |
05d5dca to
7c55551
Compare
fancyweb
commented
May 17, 2023
| @@ -25,7 +25,7 @@ function dump(mixed ...$vars): mixed | |||
| return null; | |||
| } | |||
|
|
|||
| if (isset($vars[0]) && 1 === count($vars)) { | |||
| if (array_key_exists(0, $vars) && 1 === count($vars)) { | |||
There was a problem hiding this comment.
Fix dump(null) showing 1^ null
stof
reviewed
May 17, 2023
7c55551 to
8a8b5cd
Compare
|
Thank you @fancyweb. |
Merged
|
@fancyweb @nicolas-grekas This change introduces a backwards compatibility break. See PsySH dependency test failures at dev stability starting with this change. |
|
Specifically, PsySH extends VarDumper and uses its $this->styles['label' === $style ? 'default' : $style] |
nicolas-grekas
added a commit
that referenced
this pull request
May 23, 2023
This PR was merged into the 6.3 branch. Discussion ---------- [VarDumper] Fix `dd()` showing line with `null` | Q | A | ------------- | --- | Branch? | 6.3 | Bug fix? | yes | New feature? | no | Deprecations? | no | Tickets | - | License | MIT | Doc PR | - Similar to #50347 (comment) but for the `dd()` function: ```php dd(null); ```  Commits ------- 07d318a [VarDumper] Fix `dd()` showing line with `null`
nicolas-grekas
added a commit
that referenced
this pull request
May 25, 2023
…rekas) This PR was merged into the 6.3 branch. Discussion ---------- [HttpKernel][VarDumper] Fix dumping with labels | Q | A | ------------- | --- | Branch? | 6.3 | Bug fix? | yes | New feature? | no | Deprecations? | no | Tickets | - | License | MIT | Doc PR | - Should fix #50347 (comment) /cc `@bobthecow` Also improves the display in the WDT:   Commits ------- e824eb0 [VarDumper][HttpKernel] Fix dumping with labels
symfony-splitter
pushed a commit
to symfony/var-dumper
that referenced
this pull request
May 25, 2023
…rekas) This PR was merged into the 6.3 branch. Discussion ---------- [HttpKernel][VarDumper] Fix dumping with labels | Q | A | ------------- | --- | Branch? | 6.3 | Bug fix? | yes | New feature? | no | Deprecations? | no | Tickets | - | License | MIT | Doc PR | - Should fix symfony/symfony#50347 (comment) /cc `@bobthecow` Also improves the display in the WDT:   Commits ------- e824eb051e [VarDumper][HttpKernel] Fix dumping with labels
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR fixes the handling of dumps labels when the DebugBundle is enabled and stays BC with older versions.
@javiereguiluz Unfortunately, the CSS of the web profiler toolbar is not perfect for labels and invisible characters:
Could you take care of this part plz? 🙏