10000 [Notifier] [SpotHit] Support `smslong` and `smslongnbr` API parameters by camillebaronnet · Pull Request #50136 · symfony/symfony · GitHub
[go: up one dir, main page]
Skip to content

[Notifier] [SpotHit] Support smslong and smslongnbr API parameters #50136

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jul 30, 2023
Merged

[Notifier] [SpotHit] Support smslong and smslongnbr API parameters #50136

merged 1 commit into from
Jul 30, 2023

Conversation

camillebaronnet
Copy link
Contributor
@camillebaronnet camillebaronnet commented Apr 24, 2023 •
edited by OskarStark
Loading
Q A
Branch? 6.4
Bug fix? no
New feature? yes
Deprecations? no
License MIT
Doc PR mandatory for components ?

By default, SMS via Spot Hit are strictly limited to 160 characters maximum. This PR allows to forward the corresponding arguments from the DSN to the API request to unlock this capability

@carsonbot carsonbot added this to the 6.3 milestone Apr 24, 2023
< 8000 a class="d-inline-block" data-hovercard-type="user" data-hovercard-url="/users/carsonbot/hovercard" data-octo-click="hovercard-link-click" data-octo-dimensions="link_type:self" href="/carsonbot">@carsonbot
Copy link

Hey!

I see that this is your first PR. That is great! Welcome!

Symfony has a contribution guide which I suggest you to read.

In short:

  • Always add tests
  • Keep backward compatibility (see https://symfony.com/bc).
  • Bug fixes must be submitted against the lowest maintained branch where they apply (see https://symfony.com/releases)
  • Features and deprecations must be submitted against the 6.3 branch.

Review the GitHub status checks of your pull request and try to solve the reported issues. If some tests are failing, try to see if they are failing because of this change.

When two Symfony core team members approve this change, it will be merged and you will become an official Symfony contributor!
If this PR is merged in a lower version branch, it will be merged up to all maintained branches within a few days.

I am going to sit back now and wait for the reviews.

Cheers!

Carsonbot

@carsonbot carsonbot changed the title [Notifier][SpotHit] Support SMSLong and SMSLongNBr API parameters [Notifier] [SpotHit] Support SMSLong and SMSLongNBr API parameters Apr 24, 2023
@carsonbot
Copy link

Hey!

Thanks for your PR. You are targeting branch "6.3" but it seems your PR description refers to branch "6.3 for features".
Could you update the PR description or change target branch? This helps core maintainers a lot.

Cheers!

Carsonbot

@camillebaronnet camillebaronnet changed the title [Notifier] [SpotHit] Support SMSLong and SMSLongNBr API parameters [Notifier] [SpotHit] Support smslong and `smslongnbr API parameters Apr 24, 2023
@camillebaronnet camillebaronnet changed the title [Notifier] [SpotHit] Support smslong and `smslongnbr API parameters [Notifier] [SpotHit] Support smslong and smslongnbr API parameters Apr 24, 2023
@camillebaronnet camillebaronnet force-pushed the feat/spothit-api-arguments branch 2 times, most recently from 24e8408 to bc5e80d Compare April 25, 2023 11:17
@camillebaronnet
Copy link
Contributor Author

wow sorry, the rebase notified everyone
8000

@OskarStark
Copy link
Contributor

wow sorry, the rebase notified everyone

don't worry 😃

@camillebaronnet camillebaronnet force-pushed the feat/spothit-api-arguments branch from bc5e80d to 0f389c4 Compare April 25, 2023 11:26
@OskarStark OskarStark changed the title [Notifier] [SpotHit] Support smslong and smslongnbr API parameters [Notifier][SpotHit] Support smslong and smslongnbr API parameters Apr 25, 2023
@nicolas-grekas nicolas-grekas modified the milestones: 6.3, 6.4 May 23, 2023
@carsonbot carsonbot changed the title [Notifier][SpotHit] Support smslong and smslongnbr API parameters [Notifier] [SpotHit] Support smslong and smslongnbr API parameters Jul 9, 2023
@camillebaronnet camillebaronnet force-pushed the feat/spothit-api-arguments branch from 0f389c4 to d010668 Compare July 16, 2023 14:05
@camillebaronnet camillebaronnet requested a review from fabpot July 16, 2023 14:21
@fabpot fabpot force-pushed the feat/spothit-api-arguments branch from cafc9bc to 95091a1 Compare July 30, 2023 13:19
@fabpot
Copy link
Member
fabpot commented Jul 30, 2023

Thank you @camillebaronnet.

@fabpot fabpot merged commit 888054b into symfony:6.4 Jul 30, 2023
@fabpot fabpot mentioned this pull request Jul 30, 2023
Closed
This was referenced Oct 21, 2023
Merged
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@fabpot fabpot fabpot approved these changes

@OskarStark OskarStark OskarStark approved these changes

@xabbuh xabbuh Awaiting requested review from xabbuh

@lyrixx lyrixx Awaiting requested review from lyrixx

@kbond kbond Awaiting requested review from kbond

@wouterj wouterj Awaiting requested review from wouterj

@chalasr chalasr Awaiting requested review from chalasr

@yceruto yceruto Awaiting requested review from yceruto

Assignees
No one assigned
Labels
Feature Notifier Status: Reviewed
Projects
None yet
Milestone
6.4
Development

Successfully merging this pull request may close these issues.
5 participants
@camillebaronnet @carsonbot @OskarStark @fabpot @nicolas-grekas
0