8000 fixup! fixup! [Notifier][SpotHit] Support SMSLong and SMSLongNBr API … · symfony/symfony@bc5e80d · GitHub
[go: up one dir, main page]

Skip to content
Sign in

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Appearance settings

Commit bc5e80d

Browse files
fixup! fixup! [Notifier][SpotHit] Support SMSLong and SMSLongNBr API parameters
1 parent a5c5707 commit bc5e80d

File tree

2 files changed

+16
-17
lines changed

2 files changed

+16
-17
lines changed

src/Symfony/Component/Notifier/Bridge/SpotHit/SpotHitTransport.php

+1-1
Original file line numberDiff line numberDiff line change
@@ -54,7 +54,7 @@ public function __toString(): string
5454
'smslongnbr' => $this->smsLongNBr,
5555
]);
5656

57-
return sprintf('spothit://%s', $this->getEndpoint()) . (!empty($query) ? '?' . $query : '');
57+
return sprintf('spothit://%s', $this->getEndpoint()).(!empty($query) ? '?'.$query : '');
5858
}
5959

6060
public function setSmsLong(?bool $smsLong): self

src/Symfony/Component/Notifier/Bridge/SpotHit/Tests/SpotHitTransportTest.php

+15-16
Original file line numberDiff line numberDiff line change
@@ -12,7 +12,6 @@
1212
namespace Symfony\Component\Notifier\Bridge\SpotHit\Tests;
1313

1414
use Symfony\Component\HttpClient\MockHttpClient;
15-
use Generator;
1615
use Symfony\Component\HttpClient\Response\MockResponse;
1716
use Symfony\Component\Notifier\Bridge\SpotHit\SpotHitTransport;
1817
use Symfony\Component\Notifier\Message\ChatMessage;
@@ -48,44 +47,44 @@ public static function unsupportedMessagesProvider(): iterable
4847
yield [new DummyMessage()];
4948
}
5049

51-
public function testShouldSendAMessageUsingTheSpotHitAPI(): void
50+
public function testShouldSendAMessageUsingTheSpotHitAPI()
5251
{
5352
$expectedRequest = [
54-
function($method, $url, $options) {
53+
function ($method, $url, $options) {
5554
$this->assertSame('POST', $method);
5655
$this->assertSame('https://www.spot-hit.fr/api/envoyer/sms', $url);
5756
$this->assertSame('key=&destinataires=0611223344&type=premium&message=Hello%21&expediteur=', $options['body']);
5857

5958
return new MockResponse(json_encode([
6059
'resultat' => ['success' => 'true'],
6160
'id' => '???',
62-
], JSON_THROW_ON_ERROR));
63-
}
61+
], \JSON_THROW_ON_ERROR));
62+
},
6463
];
6564

6665
$client = new MockHttpClient($expectedRequest);
6766
$transport = new SpotHitTransport('', '', $client, null);
6867
$transport->send(new SmsMessage('0611223344', 'Hello!'));
6968
}
7069

71-
public function argumentsProvider(): Generator
70+
public function argumentsProvider(): \Generator
7271
{
7372
yield [
74-
function(SpotHitTransport $transport) { $transport->setSmsLong(true); },
75-
function(array $bodyArguments) { $this->assertSame('1', $bodyArguments['smslong']); },
73+
function (SpotHitTransport $transport) { $transport->setSmsLong(true); },
74+
function (array $bodyArguments) { $this->assertSame('1', $bodyArguments['smslong']); },
7675
];
7776

7877
yield [
79-
function(SpotHitTransport $transport) { $transport->setLongNBr(3); },
80-
function(array $bodyArguments) { $this->assertSame('3', $bodyArguments['smslongnbr']); },
78+
function (SpotHitTransport $transport) { $transport->setLongNBr(3); },
79+
function (array $bodyArguments) { $this->assertSame('3', $bodyArguments['smslongnbr']); },
8180
];
8281

8382
yield [
84-
function(SpotHitTransport $transport) {
83+
function (SpotHitTransport $transport) {
8584
$transport->setSmsLong(true);
8685
$transport->setLongNBr(3);
8786
},
88-
function(array $bodyArguments) {
87+
function (array $bodyArguments) {
8988
$this->assertSame('1', $bodyArguments['smslong']);
9089
$this->assertSame('3', $bodyArguments['smslongnbr']);
9190
},
@@ -95,19 +94,19 @@ function(array $bodyArguments) {
9594
/**
9695
* @dataProvider argumentsProvider
9796
*/
98-
public function testShouldForwardArgumentToRequest($setupTransport, $assertions): void
97+
public function testShouldForwardArgumentToRequest($setupTransport, $assertions)
9998
{
10099
$expectedRequest = [
101-
function($method, $url, $options) use ($assertions) {
100+
function ($method, $url, $options) use ($assertions) {
102101
$bodyFields = [];
103102
parse_str($options['body'], $bodyFields);
104103
$assertions($bodyFields);
105104

106105
return new MockResponse(json_encode([
107106
'resultat' => ['success' => 'true'],
108107
'id' => '???',
109-
], JSON_THROW_ON_ERROR));
110-
}
108+
], \JSON_THROW_ON_ERROR));
109+
},
111110
];
112111

113112
$client = new MockHttpClient($expectedRequest);

0 commit comments

Comments
 (0)
0