8000 [Console] Do no preprend empty line if the buffer is empty by lyrixx · Pull Request #48487 · symfony/symfony · GitHub
[go: up one dir, main page]
Skip to content

[Console] Do no preprend empty line if the buffer is empty#48487

Merged
fabpot merged 1 commit intosymfony:6.3from
lyrixx:console-auto-prepend
Dec 6, 2022
Merged

[Console] Do no preprend empty line if the buffer is empty#48487
fabpot merged 1 commit intosymfony:6.3from
lyrixx:console-auto-prepend

Conversation

@lyrixx
Copy link
Copy Markdown
Member
@lyrixx lyrixx commented Dec 5, 2022
Q A
Branch? 6.3
Bug fix? no
New feature? no
Deprecations? no
Tickets
License MIT
Doc PR

It's really weird to preprend an empty line when in our code we write:

protected function execute(InputInterface $input, OutputInterface $output): int
{
    $io = new SymfonyStyle($input, $output);
    $io->text(sprintf('Running project %s', $project->getId()));
}

@lyrixx lyrixx requested a revie 8000 w from chalasr as a code owner December 5, 2022 15:52
@carsonbot carsonbot added this to the 6.3 milestone Dec 5, 2022
@fabpot
Copy link
Copy Markdown
Member
fabpot commented Dec 6, 2022

Thank you @lyrixx.

@fabpot fabpot merged commit 94d6bbb into symfony:6.3 Dec 6, 2022
@lyrixx lyrixx deleted the console-auto-prepend branch December 6, 2022 07:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@fabpot fabpot fabpot approved these changes

@chalasr chalasr Awaiting requested review from chalasr chalasr is a code owner

+1 more reviewer

@alamirault alamirault alamirault approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

Console Status: Reviewed

Projects

None yet

Milestone

6.3

Development

Successfully merging this pull request may close these issues.

4 participants

@lyrixx @fabpot @alamirault @carsonbot
0