8000 minor #48487 [Console] Do no preprend empty line if the buffer is emp… · symfony/symfony@94d6bbb · GitHub
[go: up one dir, main page]
Skip to content

Commit 94d6bbb

Browse files
fabpotfabpot
committed
minor #48487 [Console] Do no preprend empty line if the buffer is empty (lyrixx)
This PR was merged into the 6.3 branch. Discussion ---------- [Console] Do no preprend empty line if the buffer is empty | Q | A | ------------- | --- | Branch? | 6.3 | Bug fix? | no | New feature? | no | Deprecations? | no | Tickets | | License | MIT | Doc PR | It's really weird to preprend an empty line when in our code we write: ```php protected function execute(InputInterface $input, OutputInterface $output): int { $io = new SymfonyStyle($input, $output); $io->text(sprintf('Running project %s', $project->getId())); } ``` Commits ------- a9f1250 [Console] Do no preprend empty line if the buffer is empty
2 parents 4f9d8fe + a9f1250 commit 94d6bbb

File tree

4 files changed

+13
-2
lines changed

4 files changed

+13
-2
lines changed

‎src/Symfony/Component/Console/Style/SymfonyStyle.php

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -375,7 +375,7 @@ private function autoPrependText(): void
375375
{
376376
$fetched = $this->bufferedOutput->fetch();
377377
// Prepend new line if last char isn't EOL:
378-
if (!str_ends_with($fetched, "\n")) {
378+
if ($fetched && !str_ends_with($fetched, "\n")) {
379379
$this->newLine();
380380
}
381381
}

‎src/Symfony/Component/Console/Tests/Fixtures/Style/SymfonyStyle/command/command_23.php

Lines changed: 11 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,11 @@
1+
<?php
2+
3+
use Symfony\Component\Console\Input\InputInterface;
4+
use Symfony\Component\Console\Output\OutputInterface;
5+
use Symfony\Component\Console\Style\SymfonyStyle;
6+
7+
// ensure that nested tags have no effect on the color of the '//' prefix
8+
return function (InputInterface $input, OutputInterface $output) {
9+
$output = new SymfonyStyle($input, $output);
10+
$output->text('Hello');
11+
};

‎src/Symfony/Component/Console/Tests/Fixtures/Style/SymfonyStyle/output/output_23.txt

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1 @@
1+
Hello

‎src/Symfony/Component/Console/Tests/Fixtures/Style/SymfonyStyle/output/output_6.txt

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,4 +1,3 @@
1-
21
* Lorem ipsum dolor sit amet
32
* consectetur adipiscing elit
43

0 commit comments

Comments
 (0)
0