8000 [Form] [ChoiceType] Add a `placeholder_attr` option by elementaire · Pull Request #48343 · symfony/symfony · GitHub
[go: up one dir, main page]
Skip to content

[Form] [ChoiceType] Add a placeholder_attr option #48343

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Apr 8, 2023
Merged

[Form] [ChoiceType] Add a placeholder_attr option #48343

merged 1 commit into from
Apr 8, 2023

Conversation

elementaire
Copy link
Contributor
@elementaire elementaire commented Nov 26, 2022 •
edited
Loading
Q A
Branch? 6.3
Bug fix? no
New feature? yes
Deprecations? no
Tickets #38958
Similar Pull Request #47570
License MIT
Doc PR symfony/symfony-docs#17469

Allow to custom the attributes of the placeholder (data-*, title, disabled, etc.).

@carsonbot carsonbot added this to the 6.3 milestone Nov 26, 2022
@carsonbot carsonbot changed the title [Form][ChoiceType] Add a placeholder_attr option [Form] [ChoiceType] Add a placeholder_attr option Nov 26, 2022
@elementaire elementaire mentioned this pull request Nov 26, 2022
Merged
@carsonbot
Copy link

Hey!

I think @Gemorroj has recently worked with this code. Maybe they can help review this?

Cheers!

Carsonbot

@elementaire
Copy link
Contributor Author

Thoughts ?

@fabpot
Copy link
Member
fabpot commented Apr 8, 2023

Thank you @elementaire.

@fabpot fabpot merged commit 3067b9b into symfony:6.3 Apr 8, 2023
@Seb33300
Copy link
Contributor
Seb33300 commented Apr 10, 2023 •
edited
Loading

This may have some relationship to #45727

javiereguiluz added a commit to symfony/symfony-docs that referenced this pull request Jun 6, 2023
@javiereguiluz
minor #17469 [Form] Add a placeholder_attr option to ChoiceType (…
5e68a2a 
…elementaire)

This PR was merged into the 6.3 branch.

Discussion
----------

[Form] Add a `placeholder_attr` option to `ChoiceType`

PR symfony/symfony#48343

Commits
-------

8fcd394 Add a placeholder_attr option to ChoiceType
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@fabpot fabpot fabpot approved these changes

@xabbuh xabbuh xabbuh approved these changes

@yceruto yceruto Awaiting requested review from yceruto yceruto is a code owner

Assignees
No one assigned
Labels
Feature Form Status: Reviewed
Projects
None yet
Milestone
6.3
Development

Successfully merging this pull request may close these issues.
5 participants
@elementaire @carsonbot @fabpot @Seb33300 @xabbuh
0