8000 [Form] [ChoiceType] Add placeholder_disabled option by radar3301 · Pull Request #47570 · symfony/symfony · GitHub
[go: up one dir, main page]
Skip to content

[Form] [ChoiceType] Add placeholder_disabled option #47570

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wants to merge 7 commits into from
Closed

[Form] [ChoiceType] Add placeholder_disabled option #47570

wants to merge 7 commits into from

Conversation

radar3301
Copy link
Contributor
@radar3301 radar3301 commented Sep 13, 2022 •
edited
Loading
Q A
Branch? 6.2
Bug fix? no
New feature? yes
Deprecations? no
Tickets Implements #22318, #38958
License MIT
Doc PR symfony/symfony-docs#17266

Adds a placeholder_disabled option for ChoiceType, which disables the placeholder on select lists.

@carsonbot carsonbot added this to the 6.2 milestone Sep 13, 2022
@carsonbot
Copy link

Hey!

I see that this is your first PR. That is great! Welcome!

Symfony has a contribution guide which I suggest you to read.

In short:

  • Always add tests
  • Keep backward compatibility (see https://symfony.com/bc).
  • Bug fixes must be submitted against the lowest maintained branch where they apply (see https://symfony.com/releases)
  • Features and deprecations must be submitted against the 6.2 branch.

Review the GitHub status checks of your pull request and try to solve the reported issues. If some tests are failing, try to see if they are failing because of this change.

When two Symfony core team members approve this change, it will be merged and you will become an official Symfony contributor!
If this PR is merged in a lower version branch, it will be merged up to all maintained branches within a few days.

I am going to sit back now and wait for the reviews.

Cheers!

Carsonbot

@radar3301 radar3301 mentioned this pull request Sep 13, 2022
Merged
radar3301 added a commit to radar3301/symfony-docs that referenced this pull request Sep 13, 2022
@radar3301
Merge pull request #1 from radar3301/disabled-placeholder
e5e2e82 
Update choice.rst for symfony/symfony#47570
@radar3301 radar3301 mentioned this pull request Sep 13, 2022
Closed
94noni
94noni reviewed Sep 14, 2022
View reviewed changes
@radar3301
Copy link
Contributor Author

@xabbuh @yceruto any comments?

@radar3301
placeholder_disabled|default(false)
f89470d 
Default placeholder_disabled variable in twig template to false
@radar3301
Copy link
Contributor Author

What is it going to take to get this approved?

@radar3301
Copy link
Contributor Author
radar3301 commented Oct 17, 2022 •
edited
Loading

Closing as "Symfony will not implement" due to lack of review/approval. Extremely disappointing.

@radar3301 radar3301 closed this Oct 17, 2022
@94noni
Copy link
Contributor
94noni commented Oct 18, 2022

Hey @radar3301
I can understand your comment but also you may understand that the core team members are also working and preparing the feature freeze and also lot of events perhaps
If i did be you, i would reopen the PR and just wait/ping on slack if ppl are willing to review
Have a good day and chill :)

@yyywork
Copy link
yyywork commented Nov 27, 2022

hey I like this pr,
you perfectly tickled the issue many developers have been facing(like me),
It would be nice to see your commit and that will help us a lot

@elementaire elementaire mentioned this pull request Dec 17, 2022
Merged
fabpot added a commit that referenced this pull request Apr 8, 2023
@fabpot
feature #48343 [Form] [ChoiceType] Add a placeholder_attr option (e…
3067b9b 
…lementaire)

This PR was merged into the 6.3 branch.

Discussion
----------

[Form] [ChoiceType] Add a `placeholder_attr` option

| Q             | A
| ------------- | ---
| Branch?       | 6.3
| Bug fix?      | no
| New feature?  | yes
| Deprecations? | no
| Tickets       | #38958
| Similar Pull Request | #47570
| License       | MIT
| Doc PR        | symfony/symfony-docs#17469

Allow to custom the attributes of the placeholder (`data-*`, `title`, `disabled`, etc.).

Commits
-------

2d4396a [Form][ChoiceType] Add placeholder_attr field option
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@94noni 94noni 94noni left review comments

@xabbuh xabbuh Awaiting requested review from xabbuh xabbuh is a code owner

@yceruto yceruto Awaiting requested review from yceruto yceruto is a code owner

Assignees
No one assigned
Labels
Feature Form Status: Needs Review
Projects
None yet
Milestone
6.2
Development

Successfully merging this pull request may close these issues.
4 participants
@radar3301 @carsonbot @94noni @yyywork
0