8000 Check for null instead of type by ihmels · Pull Request #46913 · symfony/symfony · GitHub
[go: up one dir, main page]
Skip to content

Check for null instead of type #46913

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jul 13, 2022
Merged

Check for null instead of type #46913

merged 1 commit into from
Jul 13, 2022

Conversation

ihmels
Copy link
Contributor
@ihmels ihmels commented Jul 12, 2022
Q A
Branch? 6.2
Bug fix? no
New feature? no
Deprecations? no
Tickets n/a
License MIT
Doc PR n/a

LogoutEvent::getResponse() returns a Response or null, so it is not necessary to check the type, but whether the value is null.

@ihmels ihmels requested review from wouterj and chalasr as code owners July 12, 2022 08:02
@carsonbot carsonbot added this to the 6.2 milestone Jul 12, 2022
@wouterj wouterj modified the milestones: 6.2, 5.4 Jul 13, 2022
@wouterj wouterj changed the base branch from 6.2 to 5.4 July 13, 2022 08:25
@wouterj
Copy link
Member
wouterj commented Jul 13, 2022

Thank you, @ihmels!

@wouterj wouterj merged commit e113442 into symfony:5.4 Jul 13, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nicolas-grekas nicolas-grekas nicolas-grekas left review comments

@wouterj wouterj Awaiting requested review from wouterj

@chalasr chalasr Awaiting requested review from chalasr chalasr is a code owner

@lyrixx lyrixx Awaiting requested review from lyrixx

@yceruto yceruto Awaiting requested review from yceruto

@dunglas dunglas Awaiting requested review from dunglas

@OskarStark OskarStark Awaiting requested review from OskarStark

@jderusse jderusse Awaiting requested review from jderusse

@xabbuh xabbuh Awaiting requested review from xabbuh

Assignees
No one assigned
Labels
Status: Needs Review
Projects
None yet
Milestone
5.4
Development

Successfully merging this pull request may close these issues.
4 participants
@ihmels @wouterj @nicolas-grekas @carsonbot
0