minor #46913 Check for null instead of type (ihmels)

wouterj · wouterj · commit e1134422d0b0 · 2022-07-13T10:25:55.000+02:00
This PR was submitted for the 6.2 branch but it was merged into the 5.4 branch instead. Discussion ---------- Check for null instead of type | Q | A | ------------- | --- | Branch? | 6.2 | Bug fix? | no | New feature? | no | Deprecations? | no | Tickets | n/a | License | MIT | Doc PR | n/a `LogoutEvent::getResponse()` returns a `Response` or `null`, so it is not necessary to check the type, but whether the value is null. Commits ------- f545be9 Check for null instead of type
diff --git a/src/Symfony/Component/Security/Http/Firewall/LogoutListener.php b/src/Symfony/Component/Security/Http/Firewall/LogoutListener.php
@@ -121,8 +121,7 @@ public function authenticate(RequestEvent $event)
         $logoutEvent = new LogoutEvent($request, $this->tokenStorage->getToken());
         $this->eventDispatcher->dispatch($logoutEvent);
 
-        $response = $logoutEvent->getResponse();
-        if (!$response instanceof Response) {
+        if (!$response = $logoutEvent->getResponse()) {
             throw new \RuntimeException('No logout listener set the Response, make sure at least the DefaultLogoutListener is registered.');
         }
 

Original file line number	Diff line number	Diff line change
`@@ -121,8 +121,7 @@ public function authenticate(RequestEvent $event)`
`121`	`121`	`$logoutEvent = new LogoutEvent($request, $this->tokenStorage->getToken());`
`122`	`122`	`$this->eventDispatcher->dispatch($logoutEvent);`
`123`	`123`
`124`		`- $response = $logoutEvent->getResponse();`
`125`		`- if (!$response instanceof Response) {`
	`124`	`+ if (!$response = $logoutEvent->getResponse()) {`
`126`	`125`	`throw new \RuntimeException('No logout listener set the Response, make sure at least the DefaultLogoutListener is registered.');`
`127`	`126`	`}`
`128`	`127`