8000 [Form] Fix same choice loader with different choice values by HeahDude · Pull Request #46099 · symfony/symfony · GitHub
[go: up one dir, main page]
Skip to content

[Form] Fix same choice loader with different choice values #46099

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wants to merge 1 commit into from
Closed

[Form] Fix same choice loader with different choice values #46099

wants to merge 1 commit into from

Conversation

HeahDude
Copy link
Contributor
Q A
Branch? 5.4
Bug fix? yes
New feature? no
Deprecations? no
Tickets #44655
License MIT
Doc PR ~

Follow up of #46098 for 5.4. Supersedes #44725.

@HeahDude HeahDude requested review from xabbuh and yceruto as code owners April 18, 2022 22:45
@carsonbot carsonbot added this to the 5.4 milestone Apr 18, 2022
@HeahDude HeahDude mentioned this pull request Apr 18, 2022
Closed
@HeahDude HeahDude force-pushed the fix-choice-loader-different-choice-values-sf-5 branch from d835acc to 71048a6 Compare April 18, 2022 22:53
@xabbuh
Copy link
Member
xabbuh commented May 20, 2022

Thanks, I incorporated the needed changes into the AbstractChoiceLoader when merging 4.4 up in 01f2ace to make the test suite pass.

@xabbuh xabbuh closed this May 20, 2022
@HeahDude HeahDude deleted the fix-choice-loader-different-choice-values-sf-5 branch May 20, 2022 14:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@xabbuh xabbuh Awaiting requested review from xabbuh xabbuh is a code owner

@yceruto yceruto Awaiting requested review from yceruto yceruto is a code owner

Assignees
No one assigned
Labels
Bug Form Status: Needs Review
Projects
None yet
Milestone
5.4
Development

Successfully merging this pull request may close these issues.
3 participants
@HeahDude @xabbuh @carsonbot
0