8000 [Form] Fix `ChoiceType` with `choice_filter` and `expanded` options by cs278 · Pull Request #44725 · symfony/symfony · GitHub
[go: up one dir, main page]
Skip to content

[Form] Fix ChoiceType with choice_filter and expanded options #44725

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wants to merge 1 commit into from
Closed

[Form] Fix ChoiceType with choice_filter and expanded options #44725

wants to merge 1 commit into from

Conversation

cs278
Copy link
Contributor
@cs278 cs278 commented Dec 20, 2021
Q A
Branch? 5.3
Bug fix? yes
New feature? no
Deprecations? no
Tickets #44655 (doesn't entirely fix)
License MIT
Doc PR N/A

This fixes FilterChoiceLoaderDecorator so that it works when used by ChoiceType with the expanded option set to true. It doesn't fix the design issues with AbstractChoiceLoader breaking the ChoiceLoaderInterface contract.

@cs278 cs278 requested review from xabbuh and yceruto as code owners December 20, 2021 11:55
@carsonbot carsonbot added this to the 5.3 milestone Dec 20, 2021
@cs278 cs278 force-pushed the fix-choice-filter-expanded branch from 985e0d3 to b913930 Compare December 20, 2021 11:56
@nicolas-grekas
Copy link
Member

Anyone @symfony/mergers or someone else?

@xabbuh xabbuh modified the milestones: 5.3, 5.4 Apr 12, 2022
@xabbuh xabbuh changed the base branch from 5.3 to 5.4 April 12, 2022 13:25
@xabbuh xabbuh force-pushed the fix-choice-filter-expanded branch from b913930 to 6f54ab9 Compare April 12, 2022 13:26
@HeahDude HeahDude mentioned this pull request Apr 18, 2022
Closed
@HeahDude
Copy link
Contributor

See #46099.

@xabbuh
Copy link
Member
xabbuh commented May 20, 2022

Thank you @cs278 for raising the issue and working on a fix. We merged the fix from @HeahDude which tackles the root cause of this issue. So sadly we do not need your PR anymore. But again, thank you for reporting and giving this a try. That's really appreciated.

@xabbuh xabbuh closed this May 20, 2022
@cs278 cs278 deleted the fix-choice-filter-expanded branch December 12, 2023 17:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@xabbuh xabbuh Awaiting requested review from xabbuh xabbuh is a code owner

@yceruto yceruto Awaiting requested review from yceruto yceruto is a code owner

Assignees
No one assigned
Labels
Bug Form Status: Needs Review
Projects
None yet
Milestone
5.4
Development

Successfully merging this pull request may close these issues.
39ED
5 participants
@cs278 @nicolas-grekas @HeahDude @xabbuh @carsonbot
0