8000 [Filesystem] Replace occurrences of `operation system` to `operating system` by alexandre-daubois · Pull Request #45568 · symfony/symfony · GitHub
[go: up one dir, main page]

Skip to content

[Filesystem] Replace occurrences of operation system to operating system #45568

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Feb 28, 2022

Conversation

alexandre-daubois
Copy link
Member
Q A
Branch? 5.4
Bug fix? yes
New feature? no
Deprecations? Not sure, see below
Tickets N/A
License MIT
Doc PR N/A

Just came across this typo. I'm very unsure it is a breaking change or not. I would say yes if people are testing against the exact exception message. However, I wasn't able to find a matching rule inside the Backward Compatibility Promise page. Any idea?

@derrabus
Copy link
Member

Exception messages are not covered by the promise. Your change should be fine.

@fabpot
Copy link
Member
fabpot commented Feb 28, 2022

Thank you @alexandre-daubois.

@fabpot fabpot merged commit 45b6020 into symfony:5.4 Feb 28, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants
0