minor #45568 [Filesystem] Replace occurrences of operation system to operating system (alexandre-daubois)

fabpot · fabpot · commit 45b602070e33 · 2022-02-28T08:04:41.000+01:00
This PR was merged into the 5.4 branch. Discussion ---------- [Filesystem] Replace occurrences of `operation system` to `operating system` | Q | A | ------------- | --- | Branch? | 5.4 | Bug fix? | yes | New feature? | no | Deprecations? | **Not sure, see below** | Tickets | _N/A_ | License | MIT | Doc PR | _N/A_ Just came across this typo. I'm very unsure it is a breaking change or not. I would say yes if people are testing against the exact exception message. However, I wasn't able to find a matching rule inside the Backward Compatibility Promise page. Any idea? Commits ------- c83febc [Filesystem] Replace occurrences of `operation system` to `operating system`
diff --git a/src/Symfony/Component/Filesystem/Path.php b/src/Symfony/Component/Filesystem/Path.php
@@ -183,11 +183,11 @@ public static function getDirectory(string $path): string
      *  - UNIX
      *  - Windows8 and upper
      *
-     * If your operation system or environment isn't supported, an exception is thrown.
+     * If your operating system or environment isn't supported, an exception is thrown.
      *
      * The result is a canonical path.
      *
-     * @throws RuntimeException If your operation system or environment isn't supported
+     * @throws RuntimeException If your operating system or environment isn't supported
      */
     public static function getHomeDirectory(): string
     {
@@ -201,7 +201,7 @@ public static function getHomeDirectory(): string
             return self::canonicalize(getenv('HOMEDRIVE').getenv('HOMEPATH'));
         }
 
-        throw new RuntimeException("Cannot find the home directory path: Your environment or operation system isn't supported.");
+        throw new RuntimeException("Cannot find the home directory path: Your environment or operating system isn't supported.");
     }
 
     /**
diff --git a/src/Symfony/Component/Filesystem/Tests/PathTest.php b/src/Symfony/Component/Filesystem/Tests/PathTest.php
@@ -1024,10 +1024,10 @@ public function testJoinVarArgs()
         $this->assertSame('/path/to/test/subdir', Path::join('/path', 'to', '/test', 'subdir/'));
     }
 
-    public function testGetHomeDirectoryFailsIfNotSupportedOperationSystem()
+    public function testGetHomeDirectoryFailsIfNotSupportedOperatingSystem()
     {
         $this->expectException(\RuntimeException::class);
-        $this->expectExceptionMessage('Your environment or operation system isn\'t supported');
+        $this->expectExceptionMessage('Your environment or operating system isn\'t supported');
 
         putenv('HOME=');
 

Original file line number	Diff line number	Diff line change
`@@ -183,11 +183,11 @@ public static function getDirectory(string $path): string`
`183`	`183`	`* - UNIX`
`184`	`184`	`* - Windows8 and upper`
`185`	`185`	`*`
`186`		`- * If your operation system or environment isn't supported, an exception is thrown.`
	`186`	`+ * If your operating system or environment isn't supported, an exception is thrown.`
`187`	`187`	`*`
`188`	`188`	`* The result is a canonical path.`
`189`	`189`	`*`
`190`		`- * @throws RuntimeException If your operation system or environment isn't supported`
	`190`	`+ * @throws RuntimeException If your operating system or environment isn't supported`
`191`	`191`	`*/`
`192`	`192`	`public static function getHomeDirectory(): string`
`193`	`193`	`{`
`@@ -201,7 +201,7 @@ public static function getHomeDirectory(): string`
`201`	`201`	`return self::canonicalize(getenv('HOMEDRIVE').getenv('HOMEPATH'));`
`202`	`202`	`}`
`203`	`203`
`204`		`- throw new RuntimeException("Cannot find the home directory path: Your environment or operation system isn't supported.");`
	`204`	`+ throw new RuntimeException("Cannot find the home directory path: Your environment or operating system isn't supported.");`
`205`	`205`	`}`
`206`	`206`
`207`	`207`	`/**`
Original file line number	Diff line number	Diff line change
`@@ -1024,10 +1024,10 @@ public function testJoinVarArgs()`
`1024`	`1024`	`$this->assertSame('/path/to/test/subdir', Path::join('/path', 'to', '/test', 'subdir/'));`
`1025`	`1025`	`}`
`1026`	`1026`
`1027`		`- public function testGetHomeDirectoryFailsIfNotSupportedOperationSystem()`
	`1027`	`+ public function testGetHomeDirectoryFailsIfNotSupportedOperatingSystem()`
`1028`	`1028`	`{`
`1029`	`1029`	`$this->expectException(\RuntimeException::class);`
`1030`		`- $this->expectExceptionMessage('Your environment or operation system isn\'t supported');`
	`1030`	`+ $this->expectExceptionMessage('Your environment or operating system isn\'t supported');`
`1031`	`1031`
`1032`	`1032`	`putenv('HOME=');`
`1033`	`1033`