8000 [Mailer] Allow manually start() of SmtpTransport by jannick-holm · Pull Request #45388 · symfony/symfony · GitHub
[go: up one dir, main page]
Skip to content

[Mailer] Allow manually start() of SmtpTransport #45388

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Feb 11, 2022
Merged

[Mailer] Allow manually start() of SmtpTransport #45388

merged 1 commit into from
Feb 11, 2022

Conversation

jannick-holm
Copy link
Q A
Branch? 6.1
Bug fix? no
New feature? yes
Deprecations? no
Tickets
License MIT
Doc PR

Mark the start() method on SmtpTransport as public, to allow greater control in long running jobs and similar.

@carsonbot carsonbot added this to the 6.1 milestone Feb 10, 2022
@carsonbot
Copy link

Hey!

I see that this is your first PR. That is great! Welcome!

Symfony has a contribution guide which I suggest you to read.

In short:

  • Always add tests
  • Keep backward compatibility (see https://symfony.com/bc).
  • Bug fixes must be submitted against the lowest maintained branch where they apply (see https://symfony.com/releases)
  • Features and deprecations must be submitted against the 6.1 branch.

Review the GitHub status checks of your pull request and try to solve the reported issues. If some tests are failing, try to see if they are failing because of this change.

When two Symfony core team members approve this change, it will be merged and you will become an official Symfony contributor!
If this PR is merged in a lower version branch, it will be merged up to all maintained branches within a few days.

I am going to sit back now and wait for the reviews.

Cheers!

Carsonbot

@fabpot
Copy link
Member
fabpot commented Feb 10, 2022

Any use case? We have made the stop method public recently for long-running jobs, but the conclusion was that doing the same for the start method was not needed.

See #45307 and #43237

@jannick-holm
Copy link
Author
jannick-holm commented Feb 10, 2022 •
edited
Loading

@fabpot Sorry, forgot to add that: another use case for this, is that you could be able to test smtp credentials before saving customers smtp credentials to the database or similar without sending an email.

@fabpot
Copy link
Member
fabpot commented Feb 11, 2022

Thank you @jannick-holm.

@fabpot fabpot merged commit 2e28b5b into symfony:6.1 Feb 11, 2022
@fabpot fabpot mentioned this pull request Feb 11, 2022
Closed
@fabpot fabpot mentioned this pull request Apr 15, 2022
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@fabpot fabpot fabpot approved these changes

Assignees
No one assigned
Labels
Feature Mailer Status: Reviewed
Projects
None yet
Milestone
6.1
Development

Successfully merging this pull request may close these issues.
3 participants
@jannick-holm @carsonbot @fabpot
0