8000 [Mailer] Allow manually stop() of SmtpTransport by dvaeversted · Pull Request #45307 · symfony/symfony · GitHub
[go: up one dir, main page]
Skip to content

[Mailer] Allow manually stop() of SmtpTransport #45307

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Feb 4, 2022
Merged

[Mailer] Allow manually stop() of SmtpTransport #45307

merged 1 commit into from
Feb 4, 2022

Conversation

dvaeversted
Copy link
Contributor
@dvaeversted dvaeversted commented Feb 4, 2022 •
edited
Loading
Q A
Branch? 6.1
Bug fix? no
New feature? yes
Deprecations? no
Tickets Fix #43237
License MIT
Doc PR

Mark the stop() method on SmtpTransport as public, to allow greater control in long running jobs and similar.

@carsonbot carsonbot added this to the 6.1 milestone Feb 4, 2022
fabpot
fabpot reviewed Feb 4, 2022
View reviewed changes
@dvaeversted dvaeversted changed the title [Mailer] Allow manually start()/stop() of SmtpTransport [Mailer] Allow manually stop() of SmtpTransport Feb 4, 2022
@fabpot
Copy link
Member
fabpot commented Feb 4, 2022

Thank you @dvaeversted.

@fabpot fabpot mentioned this pull request Feb 4, 2022
Closed
@fabpot fabpot merged commit 4ad5d46 into symfony:6.1 Feb 4, 2022
@fabpot fabpot mentioned this pull request Feb 10, 2022
Merged
@dvaeversted
Copy link
Contributor Author

What is the chance of getting this merged into the 5.4 branch as well ?

https://symfony.com/blog/the-end-of-swiftmailer

According to this, Swiftmailer was disconitnued as 5.4 was released, which now puts users of the LTS releases in a limbo state if this feature is a requirement to successfully get rid of the Swiftmailer dependency.

@fabpot fabpot mentioned this pull request Apr 15, 2022
Merged
@94noni 94noni mentioned this pull request Aug 2, 2022
Merged
javiereguiluz added a commit to javiereguiluz/symfony-docs that referenced this pull request Aug 3, 2022
@javiereguiluz
minor symfony#17100 [Mailer] Document the stop() method of SmtpTransp…
6c53b67 
…ort (94noni)

This PR was merged into the 6.1 branch.

Discussion
----------

[Mailer] Document the stop() method of SmtpTransport

Ref symfony#16473
Also see the comment symfony/symfony#45307 (comment)
The text is heavily inspired by the code comment

Commits
-------

18006fb [Mailer] Document the stop() method of SmtpTransport
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@fabpot fabpot fabpot approved these changes

Assignees
No one assigned
Labels
Feature Mailer Status: Reviewed
Projects
None yet
Milestone
6.1
Development

Successfully merging this pull request may close these issues.

Ability to start & stop SMTP connection when needed
3 participants
@dvaeversted @fabpot @carsonbot
0