8000 [FrameworkBundle] Fix test to actually use data provider by kbond · Pull Request #44758 · symfony/symfony · GitHub
[go: up one dir, main page]
Skip to content

[FrameworkBundle] Fix test to actually use data provider #44758

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Dec 21, 2021
Merged

[FrameworkBundle] Fix test to actually use data provider #44758

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 1 addition & 4 deletions ...FrameworkBundle/Tests/DependencyInjection/Fixtures/php/cache_app_redis_tag_aware_pool.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,14 +2,11 @@

$container->loadFromExtension('framework', [
'cache' => [
'app' => 'cache.redis_tag_aware.bar',
'app' => 'cache.redis_tag_aware.foo',
'pools' => [
'cache.redis_tag_aware.foo' => [
'adapter' => 'cache.adapter.redis_tag_aware',
],
'cache.redis_tag_aware.bar' => [
'adapter' => 'cache.redis_tag_aware.foo',
],
],
],
]);
3 changes: 1 addition & 2 deletions ...FrameworkBundle/Tests/DependencyInjection/Fixtures/xml/cache_app_redis_tag_aware_pool.xml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -7,9 +7,8 @@

<framework:config>
<framework:cache>
<framework:app>cache.redis_tag_aware.bar</framework:app>
<framework:app>cache.redis_tag_aware.foo</framework:app>
<framework:pool name="cache.redis_tag_aware.foo" adapter="cache.adapter.redis_tag_aware" />
<framework:pool name="cache.redis_tag_aware.bar" adapter="cache.redis_tag_aware.foo" />
</framework:cache>
</framework:config>
</container>
4 changes: 1 addition & 3 deletions ...FrameworkBundle/Tests/DependencyInjection/Fixtures/yml/cache_app_redis_tag_aware_pool.yml
View file
E76F Open in desktop
Original file line number Diff line number Diff line change
@@ -1,8 +1,6 @@
framework:
cache:
app: cache.redis_tag_aware.bar
app: cache.redis_tag_aware.foo
pools:
cache.redis_tag_aware.foo:
adapter: cache.adapter.redis_tag_aware
cache.redis_tag_aware.bar:
adapter: cache.redis_tag_aware.foo
8 changes: 4 additions & 4 deletions src/Symfony/Bundle/FrameworkBundle/Tests/DependencyInjection/FrameworkExtensionTest.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1588,11 +1588,11 @@ public function testRedisTagAwareAdapter()
}

/**
* @dataProvider testAppRedisTagAwareConfigProvider
* @dataProvider appRedisTagAwareConfigProvider
*/
public function testAppRedisTagAwareAdapter()
public function testAppRedisTagAwareAdapter(string $configFile)
{
$container = $this->createContainerFromFile('cache_app_redis_tag_aware');
$container = $this->createContainerFromFile($configFile);

foreach ([TagAwareCacheInterface::class, CacheInterface::class, CacheItemPoolInterface::class] as $alias) {
$def = $container->findDefinition($alias);
Expand All @@ -1605,7 +1605,7 @@ public function testAppRedisTagAwareAdapter()
}
}

public function testAppRedisTagAwareConfigProvider(): array
public function appRedisTagAwareConfigProvider(): array
{
return [
['cache_app_redis_tag_aware'],
Expand Down
0