8000 [FrameworkBundle] Fix test to actually use data provider by kbond · Pull Request #44758 · symfony/symfony · GitHub
[go: up one dir, main page]
Skip to content

[FrameworkBundle] Fix test to actually use data provider #44758

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Dec 21, 2021
Merged

[FrameworkBundle] Fix test to actually use data provider #44758

merged 1 commit into from
Dec 21, 2021

Conversation

kbond
Copy link
Member
@kbond kbond commented Dec 21, 2021 •
edited
Loading
Q A
Branch? 5.3
Bug fix? no
New feature? no
Deprecations? no
Tickets n/a
License MIT
Doc PR n/a

#44682 didn't actually use the data provider.

@carsonbot carsonbot added this to the 5.3 milestone Dec 21, 2021
@kbond
Copy link
Member Author
kbond commented Dec 21, 2021 •
edited
Loading

When enabling this data provider, I found an issue: cache.app using a pool that inherits another pool using cache.adapter.redis_tag_aware doesn't trigger the alias to be set.

Example:

framework:
    cache:
        app: cache.redis_tag_aware.bar # cache.app.taggable is not an alias
        pools:
            cache.redis_tag_aware.foo:
                adapter: cache.adapter.redis_tag_aware
            cache.redis_tag_aware.bar:
                adapter: cache.redis_tag_aware.foo

I'm still investigating how to fix. In the meantime, I've modified the tests in this PR to just prove cache.app is aliases when using a pool that is cache.adapter.redis_tag_aware.

Edit: I believe this is ok/expected. The current code for checking if a pool is redis tag aware only looks one level down.

@kbond kbond merged commit ea3ea82 into symfony:5.3 Dec 21, 2021
@kbond kbond deleted the fix-test branch December 21, 2021 21:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@derrabus derrabus derrabus approved these changes

Assignees
No one assigned
Labels
Bug FrameworkBundle Status: Reviewed
Projects
None yet
Milestone
5.3
Development

Successfully merging this pull request may close these issues.
3 participants
@kbond @derrabus @carsonbot
0