8000 [HttpFoundation] Fix formatting session id by verng95 · Pull Request #44547 · symfony/symfony · GitHub
[go: up one dir, main page]
Skip to content

[HttpFoundation] Fix formatting session id #44547

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wants to merge 1 commit into from
Closed

[HttpFoundation] Fix formatting session id #44547

wants to merge 1 commit into from

Conversation

verng95
Copy link
@verng95 verng95 commented Dec 10, 2021
Q A
Branch? 5.4
Bug fix? yes
New feature? no
Deprecations? no
Tickets Fix #44546
License MIT
Doc PR N/A

@carsonbot carsonbot added this to the 5.4 milestone Dec 10, 2021
@carsonbot
Copy link

Hey!

I see that this is your first PR. That is great! Welcome!

Symfony has a contribution guide which I suggest you to read.

In short:

  • Always add tests
  • Keep backward compatibility (see https://symfony.com/bc).
  • Bug fixes must be submitted against the lowest maintained branch where they apply (see https://symfony.com/releases)
  • Features and deprecations must be submitted against the 6.1 branch.

Review the GitHub status checks of your pull request and try to solve the reported issues. If some tests are failing, try to see if they are failing because of this change.

When two Symfony core team members approve this change, it will be merged and you will become an official Symfony contributor!
If this PR is merged in a lower version branch, it will be merged up to all maintained branches within a few days.

I am going to sit back now and wait for the reviews.

Cheers!

Carsonbot

@chalasr
Copy link
Member
chalasr commented Dec 10, 2021

Some tests are failing with this change. Can you have a look?

@verng95
Copy link
Author
verng95 commented Dec 10, 2021

Some tests are failing with this change. Can you have a look?

Hm... locally, the tests did not show an error, I will try to reproduce the problem.

@carsonbot carsonbot changed the title Fix formatting session id [HttpFoundation] Fix formatting session id Dec 10, 2021
@verng95 verng95 closed this Dec 10, 2021
@fritzmg
Copy link
Contributor
fritzmg commented Dec 10, 2021

I can confirm that the fix would work though.

@verng95
Copy link
Author
verng95 commented Dec 10, 2021

I can confirm that the fix would work though.

Yes, but the tests fail. I can return a pull request.

@alexislefebvre
Copy link
Contributor

Maybe the tests were wrong, and they have to be updated.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
Bug HttpFoundation Status: Needs Review
Projects
None yet
Milestone
5.4
Development

Successfully merging this pull request may close these issues.
5 participants
@verng95 @carsonbot @chalasr @fritzmg @alexislefebvre
0