-
-
Notifications
You must be signed in to change notification settings - Fork 9.6k
Session is not being created after upgrade to 5.4.1 #44546
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Comments
Thanks for the details. Would you like sending a PR with the fix and a test case? |
Ok, I guess I'll do it. |
@verng95 can you confirm, that this currently only affects |
Just to clarify - what we observe is the following: if
|
@verng95 Thank you for the report. It seems currently symfony/src/Symfony/Component/HttpKernel/EventListener/AbstractSessionListener.php Line 140 in 3a1f34a
If |
Can you try out #44518 this should fix the issue with |
I can confirm that #44518 would fix the problem for us. |
Uh oh!
There was an error while loading. Please reload this page.
Symfony version(s) affected
5.4.1 or 6.0.1
Description
After upgrading to version 5.4.1/6.0.1, the session stopped working. As a result of the search, I realized that the problem was with this #44437, if you roll it back, it became normal.
How to reproduce
if
framework.session.cookie_secure: auto
is set, then:https
connections will create a sessionhttp
connections will not create a sessionPossible Solution
File
src/Symfony/Component/HttpKernel/EventListener/AbstractSessionListener.php
Line 32:If you replace this:
$sessionCookieWithId = sprintf('%s%s;', $sessionCookiePrefix, urlencode($sessionId));
On
$sessionCookieWithId = sprintf(' %s%s;', $sessionCookiePrefix, urlencode($sessionId));
That works correctly.
Additional Context
No response
The text was updated successfully, but these errors were encountered: