8000 [HttpFoundation][Sessions] Removed native save handlers · Pull Request #4454 · symfony/symfony · GitHub
[go: up one dir, main page]

Skip to content

[HttpFoundation][Sessions] Removed native save handlers #4454

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 4 commits into from May 30, 2012
Merged
Show file tree
Hide file tree
Changes from 1 commit
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Next Next commit
[HttpFoundation] Added a custom file save handler
  • Loading branch information
Drak committed May 28, 2012
commit f33b77c23e7d410489fced4670dc37715c8f9986
Original file line number Diff line number Diff line change
@@ -0,0 +1,102 @@
<?php

/*
* This file is part of the Symfony package.
*
* (c) Fabien Potencier <fabien@symfony.com>
*
* For the full copyright and license information, please view the LICENSE
* file that was distributed with this source code.
*/

namespace Symfony\Component\HttpFoundation\Session\Storage\Handler;

/**
* FileSessionHandler.
*
* @author Drak <drak@zikula.org>
*/
class FileSessionHandler implements \SessionHandlerInterface
{
/**
* @var string
*/
private $savePath;

/**
* Constructor.
*
* @param string $savePath Path of directory to save session files.
*/
public function __construct($savePath)
{
$this->savePath = $savePath;
if (false === is_dir($this->savePath)) {
mkdir($this->savePath, 0777, true);
}
}

/**
* {@inheritdoc]
*/
function open($savePath, $sessionName)
{
return true;
}

/**
* {@inheritdoc]
*/
function close()
{
return true;
}

/**
* {@inheritdoc]
*/
function read($id)
{
$file = $this->savePath.'/sess_'.$id;
if (file_exists($file)) {
return file_get_contents($file);
}

return '';
}

/**
* {@inheritdoc]
*/
function write($id, $data)
{
return false === file_put_contents($this->savePath.'/sess_'.$id, $data) ? false : true;
}

/**
* {@inheritdoc]
*/
function destroy($id)
{
$file = $this->savePath.'/sess_'.$id;
if (file_exists($file)) {
unlink($file);
}

return true;
}

/**
* {@inheritdoc]
*/
function gc($maxlifetime)
{
foreach (glob($this->savePath.'/sess_*') as $file) {
if ((filemtime($file) + $maxlifetime) < time()) {
unlink($file);
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What if someone is using the global temp folder and that contains sessions from other system users that are under different uid/gid?
Should be silenced?

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I would postulate they should not be using a shared folder for this. The code only scans for sess_* and the other alternative is to change the session file prefix. I wouldn't silence here as you it would simply hide stuff that should not be happening (due to bad configuration).

}
}

return true;
}
}
Original file line number Diff line number Diff line change
@@ -0,0 +1,104 @@
<?php

/*
* This file is part of the Symfony package.
*
* (c) Fabien Potencier <fabien@symfony.com>
*
* For the full copyright and license information, please view the LICENSE
* file that was distributed with this source code.
*/

namespace Symfony\Component\HttpFoundation\Tests\Session\Storage\Handler;

use Symfony\Component\HttpFoundation\Session\Storage\Handler\FileSessionHandler;

/**
* Test class for FileSessionHandler.
*
* @author Drak <drak@zikula.org>
*/
class FileSessionStorageTest extends \PHPUnit_Framework_TestCase
{
/**
* @var FileSessionHandler
*/
private $handler;

private $path;

public function setUp()
{
$this->path = sys_get_temp_dir().'/filesessionhandler/';
$this->handler = new FileSessionHandler($this->path);

parent::setUp();
}

public function tearDown()
{
foreach (glob($this->path.'*') as $file) {
unlink($file);
}

rmdir($this->path);

$this->handler = null;
}

public function test__construct()
{
$this->assertTrue(is_dir($this->path));
}

public function testOpen()
{
$this->assertTrue($this->handler->open('a', 'b'));
}

public function testClose()
{
$this->assertTrue($this->handler->close());
}

public function testReadWrite()
{
$this->assertEmpty($this->handler->read('123'));
$this->assertTrue($this->handler->write('123', 'data'));
$this->assertEquals('data', $this->handler->read('123'));
}

public function testDestroy()
{
$this->handler->write('456', 'data');
$this->handler->destroy('123');
$this->assertEquals('data', $this->handler->read('456'));
$this->handler->destroy('456');
$this->assertEmpty($this->handler->read('456'));
}

public function testGc()
{
$prefix = $this->path.'sess_';
$this->handler->write('1', 'data');
touch($prefix.'1', time()-86400);

$this->handler->write('2', 'data');
touch($prefix.'2', time()-3600);

$this->handler->write('3', 'data');
touch($prefix.'3', time()-300);

$this->handler->write('4', 'data');

$this->handler->gc(90000);
$this->assertEquals(4, count(glob($this->path.'*')));

$this->handler->gc(4000);
$this->assertEquals(3, count(glob($this->path.'*')));

$this->handler->gc(200);
$this->assertEquals(1, count(glob($this->path.'*')));
}
}

0