[HttpFoundation][Sessions] Removed native save handlers #4454
Conversation
Commits ------- 3c8cc0a [HttpFoundation][Sessions] Refactored tests 13a2c82 [FrameworkBundle] Refactor session file handler service name and update changelogs b2cc580 [HttpFoundation] Removed Native*Handler session save handler classes f33b77c [HttpFoundation] Added a custom file save handler Discussion ---------- [HttpFoundation][Sessions] Removed native save handlers Bug fix: no Feature addition: no Backwards compatibility break: no Symfony2 tests pass: yes Fixes the following tickets: - Todo: - License of the code: MIT Documentation PR: - Added a specific filesessionhandler Removed native handlers to slim down code. --------------------------------------------------------------------------- by travisbot at 2012-05-30T02:54:40Z This pull request [passes](http://travis-ci.org/symfony/symfony/builds/1473181) (merged 3c8cc0a into adf07f1).
| { | ||
| foreach (glob($this->getPath().'*') as $file) { | ||
| if ((filemtime($file) + $maxlifetime) < time()) { | ||
| unlink($file); |
There was a problem hiding this comment.
What if someone is using the global temp folder and that contains sessions from other system users that are under different uid/gid?
Should be silenced?
There was a problem hiding this comment.
I would postulate they should not be using a shared folder for this. The code only scans for sess_* and the other alternative is to change the session file prefix. I wouldn't silence here as you it would simply hide stuff that should not be happening (due to bad configuration).
|
I'm really wondering what was the reasoning behind this. Do I really have to provide my own redis native handler? |
|
@mvrhov - I didnt like removing them either.... I moved them to https://github.com/drak/NativeSession also available via packagist as drak/native-session |
|
@mvrhov It was removed because you can setup redis just by configuring it in php.ini. (see #4538 (comment)) |
|
@hacfi which is great if you use a whole server for a site and crappy for virtualhosting. |
|
@Drak Totally agree..I was disappointed to see it being removed as well! |
|
And this exactly is a problem. I do have the server for myself, but multitenat application will be running on it and I'd really like to prefix the session keys with unique id. I did install the NativeSession from the draks' repo, but my opinion is still what the hell. |
|
@mvrhov - I did start the beginnings of a bundle, I'll push what I have. Maybe we can all work together to make the bundle via PRs. drak/NativeSessionBundle - I've not much time atm to get it finished. |
Bug fix: no
Feature addition: no
Backwards compatibility break: no
Symfony2 tests pass: yes
Fixes the following tickets: -
Todo: -
License of the code: MIT
Documentation PR: -
Added a specific filesessionhandler
Removed native handlers to slim down code.