10000 [HttpKernel][WebProfilerBundle] adding xdebug_info page to webprofilerbundle by chr-hertel · Pull Request #44483 · symfony/symfony · GitHub
[go: up one dir, main page]

Skip to content

[HttpKernel][WebProfilerBundle] adding xdebug_info page to webprofilerbundle #44483

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Dec 7, 2021
Merged

[HttpKernel][WebProfilerBundle] adding xdebug_info page to webprofilerbundle #44483

merged 1 commit into from
Dec 7, 2021

Conversation

chr-hertel
Copy link
Contributor
Q A
Branch? 6.1
Bug fix? no
New feature? yes
Deprecations? no
Tickets n/a
License MIT
Doc PR n/a

Had a pretty annoying day and thought this should be a thing ...

Bildschirmfoto von 2021-12-06 21-03-05

@carsonbot carsonbot changed the title [WebProfilerBundle][HttpKernel] adding xdebug_info page to webprofilerbundle [HttpKernel][WebProfilerBundle] adding xdebug_info page to webprofilerbundle Dec 6, 2021
@carsonbot carsonbot added this to the 6.1 milestone Dec 6, 2021
@GromNaN
Copy link
Member
GromNaN commented Dec 7, 2021

Thanks @chr-hertel for working on this feature, this is much appreciated.

@GromNaN GromNaN merged commit 94533d4 into symfony:6.1 Dec 7, 2021
@chr-hertel chr-hertel deleted the xdebug-info-profiler branch December 7, 2021 10:14
@fabpot fabpot mentioned this pull request Apr 15, 2022
fabpot added a commit that referenced this pull request Jun 12, 2022
…ostrolucky)

This PR was merged into the 6.1 branch.

Discussion
----------

 [WebProfilerBundle] Bump http-kernel requirement to ^6.1

| Q             | A
| ------------- | ---
| Branch?       | 6.1
| Bug fix?      |  yes
| New feature?  | no
| Deprecations? | no
| Tickets       |
| License       | MIT
| Doc PR        |

Since #44483, WebProfilerBundle requires `\Symfony\Component\HttpKernel\DataCollector\ConfigDataCollector::hasXdebugInfo`, but this feature was added to http-kernel in very same PR. Hence profiler at the moment does not work with http-kernel < 6.1 (when twig strict variables are enabled, which is a default)

Commits
-------

133b165 [WebProfilerBundle] Bump http-kernel requirement to ^6.1
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants
0