-
-
Notifications
You must be signed in to change notification settings - Fork 9
Add a conflict for symfony/web-profiler-bundle #35
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Once the
contao/manager-plugin
unlocks Symfony 6, the fixed version ofsymfony/web-profiler-bundle
can automatically be installed (without removing this conflict).
Shouldn‘t we make contao/manager-plugin
compatible with Symfony 6 then instead of adding a conflict that will prevent the web profiler bundle from being installed in any set of dependencies?
It's only a conflict with the buggy version of it, 6.1.2 would be installed. I have exactly this conflict in our skeleton for example. |
So all versions from 6.0.0 to 6.1.2 are buggy? What exactly is the problem? |
Yes. They introduced it with 6.0.0 and fixed it in 6.1.2 afaik. |
May it was introduced in 6.1.0 (symfony/symfony#44483), fine for me to change it to |
But according to symfony/symfony#46650, the problem only affects Symfony 6.1.0 and 6.1.1? |
Co-authored-by: M. Vondano <m-vo@users.noreply.github.com>
Co-authored-by: Martin Auswöger <martin@auswoeger.com>
This adds a conflict for
symfony/web-profiler-bundle
due to symfony/symfony#46650 - see contao/manager-plugin#48Once the
contao/manager-plugin
unlocks Symfony 6, the fixed version ofsymfony/web-profiler-bundle
can automatically be installed (without removing this conflict).