8000 Add a conflict for symfony/web-profiler-bundle by fritzmg · Pull Request #35 · contao/conflicts · GitHub
[go: up one dir, main page]

Skip to content

Add a conflict for symfony/web-profiler-bundle #35

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Jul 20, 2022

Conversation

fritzmg
Copy link
Contributor
@fritzmg fritzmg commented Jul 20, 2022

This adds a conflict for symfony/web-profiler-bundle due to symfony/symfony#46650 - see contao/manager-plugin#48

Once the contao/manager-plugin unlocks Symfony 6, the fixed version of symfony/web-profiler-bundle can automatically be installed (without removing this conflict).

Copy link
Member
@leofeyer leofeyer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Once the contao/manager-plugin unlocks Symfony 6, the fixed version of symfony/web-profiler-bundle can automatically be installed (without removing this conflict).

Shouldn‘t we make contao/manager-plugin compatible with Symfony 6 then instead of adding a conflict that will prevent the web profiler bundle from being installed in any set of dependencies?

@bytehead
Copy link
Member
bytehead commented Jul 20, 2022

It's only a conflict with the buggy version of it, 6.1.2 would be installed. I have exactly this conflict in our skeleton for example.

@leofeyer
Copy link
Member

So all versions from 6.0.0 to 6.1.2 are buggy? What exactly is the problem?

@bytehead
Copy link
Member
bytehead commented Jul 20, 2022

Yes. They introduced it with 6.0.0 and fixed it in 6.1.2 afaik.

@bytehead
Copy link
Member

May it was introduced in 6.1.0 (symfony/symfony#44483), fine for me to change it to >=6.1, <6.1.2

@leofeyer
Copy link
Member

But according to symfony/symfony#46650, the problem only affects Symfony 6.1.0 and 6.1.1?

Co-authored-by: M. Vondano <m-vo@users.noreply.github.com>
@fritzmg fritzmg requested a review from leofeyer July 20, 2022 14:40
Co-authored-by: Martin Auswöger <martin@auswoeger.com>
@leofeyer leofeyer merged commit 499c1af into contao:main Jul 20, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants
0