10000 [Dotenv] Add $overrideExistingVars to bootEnv() and loadEnv() and dotenv_overload to SymfonyRuntime by fancyweb · Pull Request #43755 · symfony/symfony · GitHub
[go: up one dir, main page]
Skip to content

[Dotenv] Add $overrideExistingVars to bootEnv() and loadEnv() and dotenv_overload to SymfonyRuntime #43755

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Oct 26, 2021
Merged

[Dotenv] Add $overrideExistingVars to bootEnv() and loadEnv() and dotenv_overload to SymfonyRuntime #43755

merged 1 commit into from
Oct 26, 2021

Conversation

fancyweb
Copy link
Contributor
@fancyweb fancyweb commented Oct 26, 2021 •
edited
Loading
Q A
Branch? 5.4
Bug fix? no
New feature? yes
Deprecations? no
Tickets #41681 (comment)
License MIT
Doc PR -

The goal is to be able to use bootEnv() and loadEnv() and override existing vars directly instead of having to call overload() in a second time.

@carsonbot carsonbot added this to the 5.4 milestone Oct 26, 2021
@fancyweb fancyweb mentioned this pull request Oct 26, 2021
Merged
@fancyweb fancyweb force-pushed the dotenv/overload-boot-env branch from 23421bd to f26a730 Compare October 26, 2021 15:58
nicolas-grekas added a commit that referenced this pull request Oct 26, 2021
@nicolas-grekas
minor #43756 [Dotenv] Fix testBootEnv() to start from a fresh context…
1b8aa3c 
… (fancyweb)

This PR was merged into the 5.3 branch.

Discussion
----------

[Dotenv] Fix testBootEnv() to start from a fresh context

| Q             | A
| ------------- | ---
| Branch?       | 5.3
| Bug fix?      | no
| New feature?  | no
| Deprecations? | no
| Tickets       | -
| License       | MIT
| Doc PR        | -

Same reason than #43692, needed by #43755.

Commits
-------

417b9c2 [Dotenv] Fix testBootEnv() to start from a fresh context
@fancyweb fancyweb force-pushed the dotenv/overload-boot-env branch from f26a730 to 574a5be Compare October 26, 2021 16:17
@fancyweb fancyweb force-pushed the dotenv/overload-boot-env branch from 574a5be to 1411686 Compare October 26, 2021 17:02
@fancyweb fancyweb changed the title [Dotenv] Add $overrideExistingVars to bootEnv() and loadEnv() [Dotenv][Runtime] Add $overrideExistingVars to bootEnv() and loadEnv() and dotenv_overload to SymfonyRuntime Oct 26, 2021
@fancyweb fancyweb force-pushed the dotenv/overload-boot-env branch from 1411686 to bcb0592 Compare October 26, 2021 17:04
@carsonbot carsonbot changed the title [Dotenv][Runtime] Add $overrideExistingVars to bootEnv() and loadEnv() and dotenv_overload to SymfonyRuntime [Dotenv] Add $overrideExistingVars to bootEnv() and loadEnv() and dotenv_overload to SymfonyRuntime Oct 26, 2021
@nicolas-grekas
Copy link
Member

Thank you @fancyweb.

@nicolas-grekas nicolas-grekas merged commit 48b78fe into symfony:5.4 Oct 26, 2021
@nicolas-grekas nicolas-grekas mentioned this pull request Oct 26, 2021
Closed
This was referenced Nov 5, 2021
Merged
Merged
@fancyweb fancyweb deleted the dotenv/overload-boot-env branch January 11, 2022 13:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@stof stof stof left review comments

@nicolas-grekas nicolas-grekas nicolas-grekas approved these changes

Assignees
No one assigned
Labels
Dotenv Feature Status: Reviewed
Projects
None yet
Milestone
5.4
Development

Successfully merging this pull request may close these issues.
4 participants
@fancyweb @nicolas-grekas @stof @carsonbot
0