8000 [Dotenv] Fix testLoadEnv() to start from a fresh context by fancyweb · Pull Request #43692 · symfony/symfony · GitHub
[go: up one dir, main page]
Skip to content

[Dotenv] Fix testLoadEnv() to start from a fresh context #43692

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Oct 25, 2021
Merged

[Dotenv] Fix testLoadEnv() to start from a fresh context #43692

merged 1 commit into from
Oct 25, 2021

Conversation

fancyweb
Copy link
Contributor
Q A
Branch? 4.4
Bug fix? no
New feature? no
Deprecations? no
Tickets -
License MIT
Doc PR -

The current code doesn't test properly because SYMFONY_DOTENV_VARS state is not cleaned for example. We want to test "from the start" everytime here (with no state from a previous load, like it would be in a real app).

@carsonbot carsonbot added this to the 4.4 milestone Oct 25, 2021
@nicolas-grekas
Copy link
Member

Thank you @fancyweb.

@nicolas-grekas nicolas-grekas merged commit 396f1bf into symfony:4.4 Oct 25, 2021
@fancyweb fancyweb deleted the dotenv/fix-test branch October 25, 2021 12:29
@fancyweb fancyweb mentioned this pull request Oct 26, 2021
Merged
nicolas-grekas added a commit that referenced this pull request Oct 26, 2021
@nicolas-grekas
minor #43756 [Dotenv] Fix testBootEnv() to start from a fresh context…
1b8aa3c 
… (fancyweb)

This PR was merged into the 5.3 branch.

Discussion
----------

[Dotenv] Fix testBootEnv() to start from a fresh context

| Q             | A
| ------------- | ---
| Branch?       | 5.3
| Bug fix?      | no
| New feature?  | no
| Deprecations? | no
| Tickets       | -
| License       | MIT
| Doc PR        | -

Same reason than #43692, needed by #43755.

Commits
-------

417b9c2 [Dotenv] Fix testBootEnv() to start from a fresh context
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nicolas-grekas nicolas-grekas nicolas-grekas approved these changes

Assignees
No one assigned
Labels
Dotenv Status: Reviewed
Projects
None yet
Milestone
4.4
Development

Successfully merging this pull request may close these issues.
3 participants
@fancyweb @nicolas-grekas @carsonbot
0