8000 [Validator] Update validators.hr.xlf by juricav · Pull Request #43473 · symfony/symfony · GitHub
[go: up one dir, main page]
Skip to content

[Validator] Update validators.hr.xlf #43473

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Oct 15, 2021
Merged

[Validator] Update validators.hr.xlf #43473

Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
7a57f77
Update validators.hr.xlf
juricav Oct 13, 2021
13e4013
replace "ispravna" with "važeća" in translating "valid HTML/CSS"
Oct 14, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Next Next commit
Update validators.hr.xlf
  • Loading branch information
@juricav
juricav authored Oct 13, 2021
commit 7a57f7797ce560702e4b5cacfdbacb7cf071fc0f
4 changes: 4 additions & 0 deletions src/Symfony/Component/Validator/Resources/translations/validators.hr.xlf
View file
Open in desktop
8000
Original file line number Diff line number Diff line change
Expand Up @@ -390,6 +390,10 @@
<source>This value should be a valid expression.</source>
<target>Ova vrijednost mora biti valjani izraz.</target>
</trans-unit>
<trans-unit id="101">
<source>This value is not a valid CSS color.</source>
<target>Ova vrijednost nije ispravna CSS boja.</target>
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'd suggest using valjana/važeća instead of ispravna. This feels more like "the correct CSS color".

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I was considering both "ispravna" and "važeća", but went with "ispravna" since it was used in a similar translation here:

symfony/src/Symfony/Component/Form/Resources/translations/validators.hr.xlf

Lines 18 to 19 in d468bfd

<source>This value is not a valid HTML5 color.</source>
<target>Ova vrijednost nije ispravna HTML5 boja.</target>

But I agree that "važeća" sounds closer to the source string.
Can I update the file above in this PR too?

Copy link
Member
68C1

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes, you can :)

</trans-unit>
</body>
</file>
</xliff>
0