8000 [Validator] Update validators.hr.xlf by juricav · Pull Request #43473 · symfony/symfony · GitHub
[go: up one dir, main page]

Skip to content

[Validator] Update validators.hr.xlf #43473

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Oct 15, 2021
Merged

[Validator] Update validators.hr.xlf #43473

merged 2 commits into from
Oct 15, 2021

Conversation

juricav
Copy link
Contributor
@juricav juricav commented Oct 13, 2021
Q A
Branch? 4.4
Bug fix? no
New feature? no
Deprecations? no
Tickets Fix #43427
License MIT
Doc PR symfony/symfony-docs#...

Add missing translation.

@carsonbot carsonbot added this to the 4.4 milestone Oct 13, 2021
@carsonbot
Copy link

Hey!

I see that this is your first PR. That is great! Welcome!

Symfony has a contribution guide which I suggest you to read.

In short:

  • Always add tests
  • Keep backward compatibility (see https://symfony.com/bc).
  • Bug fixes must be submitted against the lowest maintained branch where they apply (see https://symfony.com/releases)
  • Features and deprecations must be submitted against the 5.4 branch.

Review the GitHub status checks of your pull request and try to solve the reported issues. If some tests are failing, try to see if they are failing because of this change.

When two Symfony core team members approve this change, it will be merged and you will become an official Symfony contributor!
If this PR is merged in a lower version branch, it will be merged up to all maintained branches within a few days.

I am going to sit back now and wait for the reviews.

Cheers!

Carsonbot

@carsonbot carsonbot changed the title Update validators.hr.xlf [Validator] Update validators.hr.xlf Oct 13, 2021
@@ -390,6 +390,10 @@
<source>This value should be a valid expression.</source>
<target>Ova vrijednost mora biti valjani izraz.</target>
</trans-unit>
<trans-unit id="101">
<source>This value is not a valid CSS color.</source>
<target>Ova vrijednost nije ispravna CSS boja.</target>
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'd suggest using valja 8000 na/važeća instead of ispravna. This feels more like "the correct CSS color".

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I was considering both "ispravna" and "važeća", but went with "ispravna" since it was used in a similar translation here:

<source>This value is not a valid HTML5 color.</source>
<target>Ova vrijednost nije ispravna HTML5 boja.</target>

But I agree that "važeća" sounds closer to the source string.
Can I update the file above in this PR too?

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes, you can :)

@fabpot
Copy link
Member
fabpot commented Oct 15, 2021

Thank you @juricav.

@fabpot fabpot merged commit 6aa673f into symfony:4.4 Oct 15, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants
0