-
-
Notifications
You must be signed in to change notification settings - Fork 9.6k
[Validator] Update validators.hr.xlf #43473
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Hey! I see that this is your first PR. That is great! Welcome! Symfony has a contribution guide which I suggest you to read. In short:
Review the GitHub status checks of your pull request and try to solve the reported issues. If some tests are failing, try to see if they are failing because of this change. When two Symfony core team members approve this change, it will be merged and you will become an official Symfony contributor! I am going to sit back now and wait for the reviews. Cheers! Carsonbot |
@@ -390,6 +390,10 @@ | |||
<source>This value should be a valid expression.</source> | |||
<target>Ova vrijednost mora biti valjani izraz.</target> | |||
</trans-unit> | |||
<trans-unit id="101"> | |||
<source>This value is not a valid CSS color.</source> | |||
<target>Ova vrijednost nije ispravna CSS boja.</target> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'd suggest using valja 8000 na/važeća instead of ispravna. This feels more like "the correct CSS color".
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I was considering both "ispravna" and "važeća", but went with "ispravna" since it was used in a similar translation here:
symfony/src/Symfony/Component/Form/Resources/translations/validators.hr.xlf
Lines 18 to 19 in d468bfd
<source>This value is not a valid HTML5 color.</source> | |
<target>Ova vrijednost nije ispravna HTML5 boja.</target> |
But I agree that "važeća" sounds closer to the source string.
Can I update the file above in this PR too?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yes, you can :)
Thank you @juricav. |
Add missing translation.