8000 [HttpKernel] Make test more robust by villfa · Pull Request #42666 · symfony/symfony · GitHub
[go: up one dir, main page]
Skip to content

[HttpKernel] Make test more robust #42666

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wants to merge 1 commit into from
Closed

[HttpKernel] Make test more robust #42666

wants to merge 1 commit into from

Conversation

villfa
Copy link
Contributor
@villfa villfa commented Aug 20, 2021
Q A
Branch? 4.4
Bug fix? no
New feature? no
Deprecations? no
Tickets n/a
License MIT
Doc PR n/a

This change should make testUploadedFileWhenSizeExceedsUploadMaxFileSize() more robust (it failed on AppVeyor before).

@carsonbot carsonbot added this to the 4.4 milestone Aug 20, 2021
@villfa villfa marked this pull request as draft August 20, 2021 20:41
@villfa villfa marked this pull request as ready for review August 20, 2021 20:47
@villfa villfa marked this pull request as draft August 20, 2021 20:51
@herndlm
Copy link
Contributor
herndlm commented Aug 20, 2021

If this returns a float conditionally it might break tests on PHP 8.1 again because SplFileInfo::getSize returns int|false (if I'm not mistaken)

@villfa
Copy link
Contributor Author
villfa commented Aug 20, 2021 •
edited
Loading

If this returns a float conditionally it might break tests on PHP 8.1 again because SplFileInfo::getSize returns int|false (if I'm not mistaken)

You are right: https://3v4l.org/qjrYC/rfc#vgit.master
I'm gonna try something else.

[EDIT] See also: https://3v4l.org/V7gYI/rfc#vgit.master

@villfa
Copy link
Contributor Author
villfa commented Aug 20, 2021

The failing tests are not related to this PR:

See the PHPUnit error report 
There were 8 failures:

1) Symfony\Component\HttpKernel\Tests\Fragment\InlineFragmentRendererTest::testRenderWithObjectsAsAttributes
Expectation failed for method name is "handle" when invoked 1 time(s)
Parameter 0 for invocation Symfony\Component\HttpKernel\HttpKernelInterface::handle(Symfony\Component\HttpFoundation\Request Object (...), 2, false) does not match expected value.
Failed asserting that two objects are equal.
--- Expected
+++ Actual
@@ @@
             'SCRIPT_FILENAME' => ''
             'SERVER_PROTOCOL' => 'HTTP/1.1'
             'REQUEST_TIME' => 1629495960
-            'REQUEST_TIME_FLOAT' => 1629495960.284396
+            'REQUEST_TIME_FLOAT' => 1629495960.284468
             'PATH_INFO' => ''
             'REQUEST_METHOD' => 'GET'
             'REQUEST_URI' => '/_fragment?_path=_format%3Dht...roller'

/home/runner/work/symfony/symfony/src/Symfony/Component/HttpKernel/HttpCache/SubRequestHandler.php:102
/home/runner/work/symfony/symfony/src/Symfony/Component/HttpKernel/Fragment/InlineFragmentRenderer.php:80
/home/runner/work/symfony/symfony/src/Symfony/Component/HttpKernel/Tests/Fragment/InlineFragmentRendererTest.php:55

2) Symfony\Component\HttpKernel\Tests\Fragment\InlineFragmentRendererTest::testRenderWithTrustedHeaderDisabled
Expectation failed for method name is "handle" when invoked 1 time(s)
Parameter 0 for invocation Symfony\Component\HttpKernel\HttpKernelInterface::handle(Symfony\Component\HttpFoundation\Request Object (...), 2, false) does not match expected value.
Failed asserting that two objects are equal.
--- Expected
+++ Actual
@@ @@
             'SCRIPT_FILENAME' => ''
             'SERVER_PROTOCOL' => 'HTTP/1.1'
             'REQUEST_TIME' => 1629495960
-            'REQUEST_TIME_FLOAT' => 1629495960.285666
+            'REQUEST_TIME_FLOAT' => 1629495960.285738
             'PATH_INFO' => ''
             'REQUEST_METHOD' => 'GET'
             'REQUEST_URI' => '/'

/home/runner/work/symfony/symfony/src/Symfony/Component/HttpKernel/HttpCache/SubRequestHandler.php:102
/home/runner/work/symfony/symfony/src/Symfony/Component/HttpKernel/Fragment/InlineFragmentRenderer.php:80
/home/runner/work/symfony/symfony/src/Symfony/Component/HttpKernel/Tests/Fragment/InlineFragmentRendererTest.php:109

3) Symfony\Component\HttpKernel\Tests\Fragment\InlineFragmentRendererTest::testLocaleAndFormatAreIsKeptInSubrequest
Expectation failed for method name is "handle" when invoked 1 time(s)
Parameter 0 for invocation Symfony\Component\HttpKernel\HttpKernelInterface::handle(Symfony\Component\HttpFoundation\Request Object (...), 2, false) does not match expected value.
Failed asserting that two objects are equal.
--- Expected
+++ Actual
@@ @@
             'SCRIPT_FILENAME' => ''
             'SERVER_PROTOCOL' => 'HTTP/1.1'
             'REQUEST_TIME' => 1629495960
-            'REQUEST_TIME_FLOAT' => 1629495960.287678
+            'REQUEST_TIME_FLOAT' => 1629495960.287741
             'PATH_INFO' => ''
             'REQUEST_METHOD' => 'GET'
             'REQUEST_URI' => '/'
             'QUERY_STRING' => ''
-            'HTTP_FORWARDED' => 'for="127.0.0.1";host="localho...o=http'
+            'HTTP_X_FORWARDED_FOR' => '127.0.0.1'
         )
     )
     'files' => Symfony\Component\HttpFoundation\FileBag Object (...)
@@ @@
             'accept' => Array (...)
             'accept-language' => Array (...)
             'accept-charset' => Array (...)
-            'forwarded' => Array (...)
+            'x-forwarded-for' => Array (...)
         )
         'cacheControl' => Array ()
     )

/home/runner/work/symfony/symfony/src/Symfony/Component/HttpKernel/HttpCache/SubRequestHandler.php:102
/home/runner/work/symfony/symfony/src/Symfony/Component/HttpKernel/Fragment/InlineFragmentRenderer.php:80
/home/runner/work/symfony/symfony/src/Symfony/Component/HttpKernel/Tests/Fragment/InlineFragmentRendererTest.php:207

4) Symfony\Component\HttpKernel\Tests\Fragment\InlineFragmentRendererTest::testESIHeaderIsKeptInSubrequest
Expectation failed for method name is "handle" when invoked 1 time(s)
Parameter 0 for invocation Symfony\Component\HttpKernel\HttpKernelInterface::handle(Symfony\Component\HttpFoundation\Request Object (...), 2, false) does not match expected value.
Failed asserting that two objects are equal.
--- Expected
+++ Actual
@@ @@
             'SCRIPT_FILENAME' => ''
             'SERVER_PROTOCOL' => 'HTTP/1.1'
             'REQUEST_TIME' => 1629495960
-            'REQUEST_TIME_FLOAT' => 1629495960.288254
+            'REQUEST_TIME_FLOAT' => 1629495960.288321
             'PATH_INFO' => ''
             'REQUEST_METHOD' => 'GET'
             'REQUEST_URI' => '/'
             'QUERY_STRING' => ''
-            'HTTP_FORWARDED' => 'for="127.0.0.1";host="localho...o=http'
+            'HTTP_X_FORWARDED_FOR' => '127.0.0.1'
         )
     )
     'files' => Symfony\Component\HttpFoundation\FileBag Object (...)
@@ @@
             'accept-language' => Array (...)
             'accept-charset' => Array (...)
             'surrogate-capability' => Array (...)
-            'forwarded' => Array (...)
+            'x-forwarded-for' => Array (...)
         )
         'cacheControl' => Array ()
     )

/home/runner/work/symfony/symfony/src/Symfony/Component/HttpKernel/HttpCache/SubRequestHandler.php:102
/home/runner/work/symfony/symfony/src/Symfony/Component/HttpKernel/Fragment/InlineFragmentRenderer.php:80
/home/runner/work/symfony/symfony/src/Symfony/Component/HttpKernel/Tests/Fragment/InlineFragmentRendererTest.php:226

5) Symfony\Component\HttpKernel\Tests\Fragment\InlineFragmentRendererTest::testESIHeaderIsKeptInSubrequestWithTrustedHeaderDisabled
Expectation failed for method name is "handle" when invoked 1 time(s)
Parameter 0 for invocation Symfony\Component\HttpKernel\HttpKernelInterface::handle(Symfony\Component\HttpFoundation\Request Object (...), 2, false) does not match expected value.
Failed asserting that two objects are equal.
--- Expected
+++ Actual
@@ @@
             'SCRIPT_FILENAME' => ''
             'SERVER_PROTOCOL' => 'HTTP/1.1'
             'REQUEST_TIME' => 1629495960
-            'REQUEST_TIME_FLOAT' => 1629495960.288827
+            'REQUEST_TIME_FLOAT' => 1629495960.288891
             'PATH_INFO' => ''
             'REQUEST_METHOD' => 'GET'
             'REQUEST_URI' => '/'

/home/runner/work/symfony/symfony/src/Symfony/Component/HttpKernel/HttpCache/SubRequestHandler.php:102
/home/runner/work/symfony/symfony/src/Symfony/Component/HttpKernel/Fragment/InlineFragmentRenderer.php:80
/home/runner/work/symfony/symfony/src/Symfony/Component/HttpKernel/Tests/Fragment/InlineFragmentRendererTest.php:226
/home/runner/work/symfony/symfony/src/Symfony/Component/HttpKernel/Tests/Fragment/InlineFragmentRendererTest.php:233

6) Symfony\Component\HttpKernel\Tests\Fragment\InlineFragmentRendererTest::testHeadersPossiblyResultingIn304AreNotAssignedToSubrequest
Expectation failed for method name is "handle" when invoked 1 time(s)
Parameter 0 for invocation Symfony\Component\HttpKernel\HttpKernelInterface::handle(Symfony\Component\HttpFoundation\Request Object (...), 2, false) does not match expected value.
Failed asserting that two objects are equal.
--- Expected
+++ Actual
@@ @@
             'SCRIPT_FILENAME' => ''
             'SERVER_PROTOCOL' => 'HTTP/1.1'
             'REQUEST_TIME' => 1629495960
-            'REQUEST_TIME_FLOAT' => 1629495960.289432
+            'REQUEST_TIME_FLOAT' => 1629495960.2895
             'PATH_INFO' => ''
             'REQUEST_METHOD' => 'GET'
             'REQUEST_URI' => '/'
             'QUERY_STRING' => ''
-            'HTTP_X_FORWARDED_FOR' => '127.0.0.1'
             'HTTP_FORWARDED' => 'for="127.0.0.1";host="localho...o=http'
         )
     )
@@ @@
             'accept' => Array (...)
             'accept-language' => Array (...)
             'accept-charset' => Array (...)
-            'x-forwarded-for' => Array (...)
             'forwarded' => Array (...)
         )
         'cacheControl' => Array ()

/home/runner/work/symfony/symfony/src/Symfony/Component/HttpKernel/HttpCache/SubRequestHandler.php:102
/home/runner/work/symfony/symfony/src/Symfony/Component/HttpKernel/Fragment/InlineFragmentRenderer.php:80
/home/runner/work/symfony/symfony/src/Symfony/Component/HttpKernel/Tests/Fragment/InlineFragmentRendererTest.php:248

7) Symfony\Component\HttpKernel\Tests\Fragment\InlineFragmentRendererTest::testFirstTrustedProxyIsSetAsRemote
Expectation failed for method name is "handle" when invoked 1 time(s)
Parameter 0 for invocation Symfony\Component\HttpKernel\HttpKernelInterface::handle(Symfony\Component\HttpFoundation\Request Object (...), 2, false) does not match expected value.
Failed asserting that two objects are equal.
--- Expected
+++ Actual
@@ @@
             'SCRIPT_FILENAME' => ''
             'SERVER_PROTOCOL' => 'HTTP/1.1'
             'REQUEST_TIME' => 1629495960
-            'REQUEST_TIME_FLOAT' => 1629495960.290026
+            'REQUEST_TIME_FLOAT' => 1629495960.290094
             'PATH_INFO' => ''
             'REQUEST_METHOD' => 'GET'
             'REQUEST_URI' => '/'

/home/runner/work/symfony/symfony/src/Symfony/Component/HttpKernel/HttpCache/SubRequestHandler.php:102
/home/runner/work/symfony/symfony/src/Symfony/Component/HttpKernel/Fragment/InlineFragmentRenderer.php:80
/home/runner/work/symfony/symfony/src/Symfony/Component/HttpKernel/Tests/Fragment/InlineFragmentRendererTest.php:267

8) Symfony\Component\HttpKernel\Tests\Fragment\InlineFragmentRendererTest::testIpAddressOfRangedTrustedProxyIsSetAsRemote
Expectation failed for method name is "handle" when invoked 1 time(s)
Parameter 0 for invocation Symfony\Component\HttpKernel\HttpKernelInterface::handle(Symfony\Component\HttpFoundation\Request Object (...), 2, false) does not match expected value.
Failed asserting that two objects are equal.
--- Expected
+++ Actual
@@ @@
             'SCRIPT_FILENAME' => ''
             'SERVER_PROTOCOL' => 'HTTP/1.1'
             'REQUEST_TIME' => 1629495960
-            'REQUEST_TIME_FLOAT' => 1629495960.290641
+            'REQUEST_TIME_FLOAT' => 1629495960.29071
             'PATH_INFO' => ''
             'REQUEST_METHOD' => 'GET'
             'REQUEST_URI' => '/'

/home/runner/work/symfony/symfony/src/Symfony/Component/HttpKernel/HttpCache/SubRequestHandler.php:102
/home/runner/work/symfony/symfony/src/Symfony/Component/HttpKernel/Fragment/InlineFragmentRenderer.php:80
/home/runner/work/symfony/symfony/src/Symfony/Component/HttpKernel/Tests/Fragment/InlineFragmentRendererTest.php:288

FAILURES!
Tests: 705, Assertions: 1741, Failures: 8.

@villfa villfa marked this pull request as ready for review August 20, 2021 21:55
@derrabus
Copy link
Member

See #42629

@villfa
Copy link
Contributor Author
villfa commented Aug 25, 2021

Closing in favor of #42718

@villfa villfa closed this Aug 25, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
HttpKernel Status: Needs Review
Projects
None yet
Milestone
4.4
Development

Successfully merging this pull request may close these issues.
4 participants
@villfa @herndlm @derrabus @carsonbot
2A9B
0