AppVeyor: Reduce upload_max_filesize below PHP_INT_MAX #42629
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Alexander M. Turek <me@derrabus.de>
chalasr
approved these changes
Aug 18, 2021
|
Doesn't this reduce the coverage on 32b? |
|
Does it? |
|
I think it does: these ini values have been added in #39633 to cover parsing |
|
I see. Shall I skip the failing test on 32bit instead? |
|
👍 to skip it |
|
Closing in favor of #42718, thanks for the PR. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The changes from #42618 made the tests on AppVeyor fail. The reason is that the test depends on the php.ini setting
upload_max_filesize. The test picks the highest integer value available (PHP_INT_MAX), assuming that this value is higher thanupload_max_filesizein Bytes. On AppVeyor, we test with a 32bit build of PHP and aupload_max_filesizesetting of4G. The fact that 4 Gigabytes in Bytes produce a number that cannot be represented with a 32bit integer contradicts with that assumption.This PR lowers
upload_max_filesizeto1Gso that we have a chance to test with integer values that are higher than this setting.