8000 [Security] Deprecate legacy remember me services by wouterj · Pull Request #42578 · symfony/symfony · GitHub
[go: up one dir, main page]
Skip to content

[Security] Deprecate legacy remember me services #42578

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Aug 16, 2021
Merged

[Security] Deprecate legacy remember me services #42578

merged 1 commit into from
Aug 16, 2021

Conversation

wouterj
Copy link
Member
@wouterj wouterj commented Aug 15, 2021
Q A
Branch? 5.4
Bug fix? no
New feature? no
Deprecations? yes
Tickets -
License MIT
Doc PR -

I was wrong :(, there is more to deprecate in security: the old remember me implementation.

@wouterj wouterj requested a review from chalasr as a code owner August 15, 2021 11:21
@wouterj wouterj force-pushed the pull-41613/rememberme branch 2 times, most recently from 81010f9 to a31a2ee Compare August 15, 2021 11:29
@wouterj
Copy link
Member Author
wouterj commented Aug 15, 2021

Fabbot error is a false positive

@carsonbot
Copy link

Hey!

I think @dmaicher has recently worked with this code. Maybe they can help review this?

Cheers!

Carsonbot

@wouterj wouterj mentioned this pull request Aug 16, 2021
Merged
fabpot
fabpot approved these changes Aug 16, 2021
View reviewed changes
src/Symfony/Component/Security/Http/CHANGELOG.md Outdated
@@ -1,9 +1,12 @@
CHANGELOG
=========


Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

extra white line

@fabpot fabpot force-pushed the pull-41613/rememberme branch from a31a2ee to 03e5da1 Compare August 16, 2021 08:26
@fabpot
Copy link
Member
fabpot commented Aug 16, 2021

Thank you @wouterj.

@fabpot fabpot merged commit d1a2d21 into symfony:5.4 Aug 16, 2021
@fabpot fabpot mentioned this pull request Aug 16, 2021
Closed
@wouterj wouterj deleted the pull-41613/rememberme branch August 16, 2021 08:35
This was referenced Nov 5, 2021
Merged
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@fabpot fabpot fabpot approved these changes

@chalasr chalasr Awaiting requested review from chalasr chalasr is a code owner

Assignees
No one assigned
Labels
Deprecation Security Status: Reviewed
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@wouterj @carsonbot @fabpot
0