[HttpFoundation] Fix str_contains type mismatch in ApacheRequest #42317
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I don't think that this change is necessary. This class is meant to be used when serving a request inside an Apache HTTPd. And in that context, |
|
Should is not must, but I agree that this will be an uncommon if not ever happening case. Anyways, feel free to close it, that's also why I made this a separate PR! |
Let's close then. I'd rather not change that class unless someone really encounters an issue with this.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When scanning for more possible error like fixed in #42316, I found this one. I decided to create a separate MR as I'm not sure falling back to
/would be the desired behaviour for a missingREQUEST_URI, or that maybe an exception would be more suitable.