8000 [Security] Fix str_contains type mismatch in ChannelListener by bobvandevijver · Pull Request #42316 · symfony/symfony · GitHub
[go: up one dir, main page]
Skip to content

[Security] Fix str_contains type mismatch in ChannelListener #42316

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jul 30, 2021
Merged

[Security] Fix str_contains type mismatch in ChannelListener #42316

merged 1 commit into from
Jul 30, 2021

Conversation

bobvandevijver
Copy link
Contributor
@bobvandevijver bobvandevijver commented Jul 29, 2021 •
edited by derrabus
Loading
Q A
Branch? 4.4
Bug fix? yes
New feature? no
Deprecations? no
Tickets Fix #42300, Part of #41552
License MIT
Doc PR -

Also use a default empty string in the ChannelListener before using str_contains.

@carsonbot carsonbot added this to the 4.4 milestone Jul 29, 2021
@bobvandevijver bobvandevijver mentioned this pull request Jul 29, 2021
Closed
@bobvandevijver bobvandevijver mentioned this pull request Jul 29, 2021
Merged
derrabus
derrabus approved these changes Jul 29, 2021
View reviewed changes
Copy link
Member
@derrabus derrabus left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just a minor comment.

@derrabus
Copy link
Member

Context: We need this change for #41552.

@fabpot fabpot force-pushed the fix-type-mismatches branch from 578fb95 to 28ae62d Compare July 30, 2021 10:29
@fabpot
Copy link
Member
fabpot commented Jul 30, 2021

Thank you @bobvandevijver.

@fabpot fabpot merged commit af897a1 into symfony:4.4 Jul 30, 2021
@bobvandevijver bobvandevijver deleted the fix-type-mismatches branch July 31, 2021 07:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@fabpot fabpot fabpot approved these changes

@derrabus derrabus derrabus approved these changes

@chalasr chalasr Awaiting requested review from chalasr chalasr is a code owner

@wouterj wouterj Awaiting requested review from wouterj wouterj is a code owner

Assignees
No one assigned
Labels
Bug Security Status: Reviewed
Projects
None yet
Milestone
4.4
Development

Successfully merging this pull request may close these issues.
4 participants
@bobvandevijver @derrabus @fabpot @carsonbot
0