8000 [Notifier] Do not use static::class for final messages by norkunas · Pull Request #41736 · symfony/symfony · GitHub
[go: up one dir, main page]
Skip to content

[Notifier] Do not use static::class for final messages #41736

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wants to merge 0 commits into from
Closed

[Notifier] Do not use static::class for final messages #41736

wants to merge 0 commits into from

Conversation

norkunas
Copy link
Contributor
@norkunas norkunas commented Jun 18, 2021 •
edited by nicolas-grekas
Loading
Q A
Branch? 5.2
Bug fix? no
New feature? no
Deprecations? no
Tickets #39402 (comment)
License MIT
Doc PR N/A

Micro optimization

@norkunas norkunas requested a review from OskarStark as a code owner June 18, 2021 03:40
@carsonbot
Copy link

Hey!

I think @jschaedl has recently worked with this code. Maybe they can help review this?

Cheers!

Carsonbot

@nicolas-grekas nicolas-grekas added this to the 5.2 milestone Jun 21, 2021
@nicolas-grekas nicolas-grekas changed the base branch from 5.4 to 5.2 June 21, 2021 12:11
@nicolas-grekas
Copy link
Member

Thank you @norkunas.

nicolas-grekas added a commit that referenced this pull request Jun 21, 2021
@nicolas-grekas
minor #41736 [Notifier] Do not use static::class for final messages (…
46befa8 
…norkunas)

This PR was submitted for the 5.4 branch but it was merged into the 5.2 branch instead.

Discussion
----------

[Notifier] Do not use static::class for final messages

| Q             | A
| ------------- | ---
| Branch?       | 5.4
| Bug fix?      | no
| New feature?  | no
| Deprecations? | no
| Tickets       | #39402 (comment)
| License       | MIT
| Doc PR        | N/A

Micro optimization

Commits
-------

69f6409 Do not use static::class for final messages
@norkunas norkunas deleted the no-static branch June 21, 2021 12:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@OskarStark OskarStark Awaiting requested review from OskarStark

@chalasr chalasr Awaiting requested review from chalasr

@dunglas dunglas Awaiting requested review from dunglas

@lyrixx lyrixx Awaiting requested review from lyrixx

@wouterj wouterj Awaiting requested review from wouterj

@xabbuh xabbuh Awaiting requested review from xabbuh

@yceruto yceruto Awaiting requested review from yceruto

Assignees
No one assigned
Labels
Notifier Status: Needs Review
Projects
None yet
Milestone
5.2
Development

Successfully merging this pull request may close these issues.
3 participants
@norkunas @carsonbot @nicolas-grekas
0