minor #41736 [Notifier] Do not use static::class for final messages (norkunas)

nicolas-grekas · nicolas-grekas · commit 46befa83042a · 2021-06-21T14:11:27.000+02:00
This PR was submitted for the 5.4 branch but it was merged into the 5.2 branch instead. Discussion ---------- [Notifier] Do not use static::class for final messages | Q | A | ------------- | --- | Branch? | 5.4 | Bug fix? | no | New feature? | no | Deprecations? | no | Tickets | #39402 (comment) | License | MIT | Doc PR | N/A Micro optimization Commits ------- 69f6409 Do not use static::class for final messages
diff --git a/src/Symfony/Component/Notifier/Message/EmailMessage.php b/src/Symfony/Component/Notifier/Message/EmailMessage.php
@@ -39,7 +39,7 @@ public function __construct(RawMessage $message, Envelope $envelope = null)
     public static function fromNotification(Notification $notification, EmailRecipientInterface $recipient): self
     {
         if ('' === $recipient->getEmail()) {
-            throw new InvalidArgumentException(sprintf('"%s" needs an email, it cannot be empty.', static::class));
+            throw new InvalidArgumentException(sprintf('"%s" needs an email, it cannot be empty.', __CLASS__));
         }
 
         if (!class_exists(NotificationEmail::class)) {
diff --git a/src/Symfony/Component/Notifier/Message/SmsMessage.php b/src/Symfony/Component/Notifier/Message/SmsMessage.php
@@ -29,7 +29,7 @@ final class SmsMessage implements MessageInterface
     public function __construct(string $phone, string $subject)
     {
         if ('' === $phone) {
-            throw new InvalidArgumentException(sprintf('"%s" needs a phone number, it cannot be empty.', static::class));
+            throw new InvalidArgumentException(sprintf('"%s" needs a phone number, it cannot be empty.', __CLASS__));
         }
 
         $this->subject = $subject;

Original file line number	Diff line number	Diff line change
`@@ -39,7 +39,7 @@ public function __construct(RawMessage $message, Envelope $envelope = null)`
`39`	`39`	`public static function fromNotification(Notification $notification, EmailRecipientInterface $recipient): self`
`40`	`40`	`{`
`41`	`41`	`if ('' === $recipient->getEmail()) {`
`42`		`- throw new InvalidArgumentException(sprintf('"%s" needs an email, it cannot be empty.', static::class));`
	`42`	`+ throw new InvalidArgumentException(sprintf('"%s" needs an email, it cannot be empty.', __CLASS__));`
`43`	`43`	`}`
`44`	`44`
`45`	`45`	`if (!class_exists(NotificationEmail::class)) {`
Original file line number	Diff line number	Diff line change
`@@ -29,7 +29,7 @@ final class SmsMessage implements MessageInterface`
`29`	`29`	`public function __construct(string $phone, string $subject)`
`30`	`30`	`{`
`31`	`31`	`if ('' === $phone) {`
`32`		`- throw new InvalidArgumentException(sprintf('"%s" needs a phone number, it cannot be empty.', static::class));`
	`32`	`+ throw new InvalidArgumentException(sprintf('"%s" needs a phone number, it cannot be empty.', __CLASS__));`
`33`	`33`	`}`
`34`	`34`
`35`	`35`	`$this->subject = $subject;`