[HttpFoundation] Remove dead code for emulating SameSite cookie #41448
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
e0684a2 to
a0a935a
Compare
stof
reviewed
May 29, 2021
| @@ -157,13 +151,6 @@ public function start() | |||
| throw new \RuntimeException('Failed to start the session.'); | |||
| } | |||
|
|
|||
| if (null !== $this->emulateSameSite) { | |||
| $originalCookie = SessionUtils::popSessionCookie(session_name(), session_id()); | |||
There was a problem hiding this comment.
is this SessionUtils::popSessionCookie utility method still necessary then or should it also be removed ?
There was a problem hiding this comment.
It’s still used elsewhere.
nicolas-grekas
approved these changes
May 31, 2021
|
Thank you @mbabker. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Follow up to #41295, the code setting the
$emulateSameSiteproperty was based on a PHP version conditional that's no longer used.