8000 Remove constraint for PHP < 8 by jderusse · Pull Request #41295 · symfony/symfony · GitHub
[go: up one dir, main page]
Skip to content

Remove constraint for PHP < 8 #41295

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
May 23, 2021
Merged

Remove constraint for PHP < 8 #41295

merged 1 commit into from
May 23, 2021

Conversation

jderusse
Copy link
Member
Q A
Branch? 6.0
Bug fix? no
New feature? no
Deprecations? no
Tickets -
License MIT
Doc PR -

Remove code check against PHP_VERSION < 8 (except for PHPUnit Bridge)

@carsonbot carsonbot added this to the 6.0 milestone May 19, 2021
DavidBadura
DavidBadura reviewed May 19, 2021
View reviewed changes
derrabus
derrabus requested changes May 19, 2021
View reviewed changes
derrabus
derrabus requested changes May 19, 2021
View reviewed changes
@derrabus
Copy link
Member

Some Tests in ReflectionCasterTest and CliDumperTest are failing: https://travis-ci.com/github/symfony/symfony/jobs/506482134#L9345

I believe this happens because of accidentally deleted trailing spaces again.

@jderusse jderusse force-pushed the phpversion branch 3 times, most recently from ad22641 to 8b23013 Compare May 19, 2021 21:44
@derrabus derrabus mentioned this pull request May 20, 2021
Merged
derrabus added a commit that referenced this pull request May 20, 2021
@derrabus
minor #41345 [FrameworkBundle] Return early (derrabus)
68224c2 
This PR was merged into the 4.4 branch.

Discussion
----------

[FrameworkBundle] Return early

| Q             | A
| ------------- | ---
| Branch?       | 4.4
| Bug fix?      | no
| New feature?  | no
| Deprecations? | no
| Tickets       | #41295 (comment)
| License       | MIT
| Doc PR        | N/A

Commits
-------

b6c8aa5 [FrameworkBundle] Return early
@nicolas-grekas
Copy link
Member

Thank you @jderusse.

@nicolas-grekas nicolas-grekas merged commit 2557a40 into symfony:6.0 May 23, 2021
@jderusse jderusse deleted the phpversion branch May 23, 2021 10:17
@mbabker mbabker mentioned this pull request May 29, 2021
Merged
nicolas-grekas added a commit that referenced this pull request May 31, 2021
@nicolas-grekas
minor #41448 [HttpFoundation] Remove dead code for emulating SameSite…
17800d1 
… cookie (mbabker)

This PR was merged into the 6.0 branch.

Discussion
----------

[HttpFoundation] Remove dead code for emulating SameSite cookie

| Q             | A
| ------------- | ---
| Branch?       | 6.0
| Bug fix?      | no
| New feature?  | no
| Deprecations? | no
| Tickets       | N/A
| License       | MIT
| Doc PR        | N/A

Follow up to #41295, the code setting the `$emulateSameSite` property was based on a PHP version conditional that's no longer used.

Commits
-------

a0a935a Remove dead code for emulating SameSite cookie
@alamirault alamirault mentioned this pull request Feb 22, 2023
Merged
nicolas-grekas added a commit that referenced this pull request Feb 22, 2023
@nicolas-grekas
minor #49501 [String] Remove unused private constant (alamirault)
2c75ab7 
This PR was merged into the 6.3 branch.

Discussion
----------

[String] Remove unused private constant

| Q             | A
| ------------- | ---
| Branch?       | 6.3
| Bug fix?      | no
| New feature?  | no <!-- please update src/**/CHANGELOG.md files -->
| Deprecations? | no <!-- please update UPGRADE-*.md and src/**/CHANGELOG.md files -->
| Tickets       | Fix #... <!-- prefix each issue number with "Fix #", no need to create an issue if none exists, explain below instead -->
| License       | MIT
| Doc PR        | symfony/symfony-docs#... <!-- required for new features -->

I searched unused private properties in all components and found this case.

Usage of these constants was drop in #41295

Commits
-------

892b08f [String] Remove unused private constant
PhilETaylor pushed a commit to PhilETaylor/symfony that referenced this pull request Sep 6, 2023
@nicolas-grekas
minor symfony#41295 Remove constraint for PHP < 8 (jderusse)
4f0b4c3 
This PR was squashed before being merged into the 6.0 branch.

Discussion
----------

Remove constraint for PHP < 8

| Q             | A
| ------------- | ---
| Branch?       | 6.0
| Bug fix?      | no
| New feature?  | no
| Deprecations? | no
| Tickets       | -
| License       | MIT
| Doc PR        | -

Remove code check against PHP_VERSION < 8 (except for PHPUnit Bridge)

Commits
-------

a8c74ae Remove constraint for PHP < 8
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nicolas-grekas nicolas-grekas nicolas-grekas left review comments

@GromNaN GromNaN GromNaN left review comments

@DavidBadura DavidBadura DavidBadura left review comments

@derrabus derrabus derrabus approved these changes

@chalasr chalasr Awaiting requested review from chalasr chalasr is a code owner

@dunglas dunglas Awaiting requested review from dunglas dunglas is a code owner

@wouterj wouterj Awaiting requested review from wouterj wouterj is a code owner

@xabbuh xabbuh Awaiting requested review from xabbuh xabbuh is a code owner

@yceruto yceruto Awaiting requested review from yceruto yceruto is a code owner

Assignees
No one assigned
Labels
Status: Reviewed
Projects
None yet
Milestone
6.0
Development

Successfully merging this pull request may close these issues.
6 participants
@jderusse @derrabus @nicolas-grekas @GromNaN @DavidBadura @carsonbot
0