10000 [WIP][2.1][Form] Revert some BC breaks by vicb · Pull Request #4134 · symfony/symfony · GitHub
[go: up one dir, main page]
Skip to content

[WIP][2.1][Form] Revert some BC breaks #4134

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wants to merge 8 commits into from
Closed

[WIP][2.1][Form] Revert some BC breaks #4134

wants to merge 8 commits into from

Conversation

vicb
Copy link
Contributor
@vicb vicb commented Apr 27, 2012

Build Status

Some BC breaks have been removed from the 2.1 branch to ease the 2.0 to 2.1 transition.

Most changes will still be kept and fixed the master branch (#2421 will also be reverted in the main branch).

BC breaks that have not been reverted:

This is a preview, feedback is appreciated.

vicb added 8 commits April 27, 2012 13:27
@vicb
[Form] Revert "merged branch bschussek/issue3990 (PR symfony#3996)"
76bbcaf 
This reverts commit aebaece, reversing
changes made to fd52f93.
@vicb
[Form] Revert "merged branch vicb/FormTypeValidatorExtension_fix (PR s…
a47148b 
…ymfony#3984)"

This reverts commit 83a0edd, reversing
changes made to 065632b.
@vicb
[Form] Revert "merged branch bschussek/issue3878 (PR symfony#3923)"
d361072 
This reverts commit 85bb439, reversing
changes made to 962f975.

Conflicts:

	CHANGELOG-2.1.md
	UPGRADE-2.1.md
	src/Symfony/Component/Form/Extension/Core/Type/FormType.php
	src/Symfony/Component/Form/Tests/FormFactoryTest.php

s3923
@vicb
[Form] Restore missing use statements
1c7c99d
@vicb
[Form] Revert "merged branch helmer/readonly_fix (PR symfony#3258)"
43604e2 
This reverts commit 5251177, reversing
changes made to ffef177.
@vicb
[Form] Revert "merged branch helmer/readonly (PR symfony#3193)"
ccd8b67 
This reverts commit e71d157, reversing
changes made to 253a8ff.

Conflicts:

	src/Symfony/Component/Form/Form.php
	src/Symfony/Component/Form/Tests/FormFactoryTest.php
@vicb
[Form] Revert "merged branch stloyd/missingClientTransformer (PR symf…
2440349 
…ony#2421)"

This reverts commit 7ea9c5b, reversing
changes made to 5803146.

Conflicts:

	src/Symfony/Component/Form/Tests/Extension/Core/DataTransformer/ValueToStringTransformerTest.php
@vicb
[Form] Updated the changelog in regards to the reverted changes
12b3a05 
This reverts commit e71d157, reversing
changes made to 253a8ff.

Conflicts:

	src/Symfony/Component/Form/Form.php
	src/Symfony/Component/Form/Tests/FormFactoryTest.php

Conflicts:

	CHANGELOG-2.1.md
@ghost
Copy link
ghost commented May 2, 2012

I think it would be better not to revert anything. As @fabpot said, if we're going to make BC breaks, let's do it big once, so that future releases will be more stable.

@rdohms
Copy link
Contributor
rdohms commented May 2, 2012

I agree, most bundles and everyone working on 2.1 have already made the changes to reflect the form changes, reverting all that no would just give everyone more grief.

As has been said, forms was not stable, so i would just make it all stable now and reduce refactor costs up ahead.

@vicb vicb closed this May 10, 2012
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
Form
Projects
None yet
Milestone
2.1
Development

Successfully merging this pull request may close these issues.
2 participants
@vicb @rdohms
0