[Form] Made validation of form children configurable #3128
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…"cascade_validation" to `true` if you need it.
|
👍 |
fabpot
added a commit
that referenced
this pull request
Jan 16, 2012
Commits ------- 0c70a41 [Form] Made validation of form children configurable. Set the option "cascade_validation" to `true` if you need it. Discussion ---------- [Form] Made validation of form children configurable Bug fix: yes Feature addition: yes Backwards compatibility break: yes Symfony2 tests pass: yes Fixes the following tickets: #797 Todo: adapt documentation  Child forms now aren't validated anymore by default. This is not a problem as long as @Valid constraints are properly put in your model. If you want to enable cascading validation, for example when there is no connection between the parent and the child model, you can set the option "cascade_validation" in the parent form to true. This change is not backwards compatible, but from my estimation the break should not affect many applications. --------------------------------------------------------------------------- by kriswallsmith at 2012-01-16T19:59:25Z :+1:
|
merged, thanks. Don't forget to update the CHANGELOG and the UPGRADE file as well. I've done the former here: 172300e |
|
Using |
|
@craue Could you open a ticket with more details please? |
|
@bschussek: See #3219. |
|
Hi, one problem I have found is that using @Valid doesn't work when using validation_groups in the child form options. Is this considered a problem or is putting validation groups in child forms simply not done ? |
|
@guillaumesmo: You are right this doesn't work and there should be ticket opened about that, however I'm unable to find it. |
|
keep me informed if you do it, otherwise i'll post a ticket in a few hours |
|
OK, issue posted here: #9650 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Bug fix: yes
Feature addition: yes
Backwards compatibility break: yes
Symfony2 tests pass: yes
Fixes the following tickets: #797
Todo: adapt documentation
Child forms now aren't validated anymore by default. This is not a problem as long as @Valid constraints are properly put in your model. If you want to enable cascading validation, for example when there is no connection between the parent and the child model, you can set the option "cascade_validation" in the parent form to true.
This change is not backwards compatible, but from my estimation the break should not affect many applications.