[HttpClient] Avoid installation of latest contracts as it's not compatible #41001
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I added a Fixes... for the open ticket to the PR header |
OskarStark
approved these changes
Apr 30, 2021
stof
requested changes
Apr 30, 2021
| @@ -23,7 +23,7 @@ | |||
| "require": { | |||
| "php": ">=7.1.3", | |||
| "psr/log": "^1.0", | |||
| "symfony/http-client-contracts": "^1.1.10|^2", | |||
| "symfony/http-client-contracts": "^1.1.10|<2.4", | |||
There was a problem hiding this comment.
should be ^1.1.10|>=2,<2.4. Otherwise, the <2.4 constraint allows to install 1.0.0
|
HttpClient is compatible with Contracts 2.4. It "just" triggers a deprecation when used with it, but that can be ignored. I think we should try patching |
|
It just trigger deprecation notice because we ensure to not break BC. That's why we added |
|
Closing in favor of #41075 |
derrabus
added a commit
that referenced
this pull request
May 3, 2021
… for `Symfony\*` classes unless symfony/symfony is being tested (nicolas-grekas) This PR was merged into the 4.4 branch. Discussion ---------- [ErrorHandler] Skip "same vendor" ``@method`` deprecations for `Symfony\*` classes unless symfony/symfony is being tested | Q | A | ------------- | --- | Branch? | 4.4 | Bug fix? | yes | New feature? | no | Deprecations? | no | Tickets | ref #40975 #40996 #40893 | License | MIT | Doc PR | Replaces #41001 Commits ------- 7a1a910 [ErrorHandler] Skip "same vendor" ``@method`` deprecations for `Symfony\*` classes unless symfony/symfony is being tested
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
To be reverted on 5.x (5.3)
Fixes #40975