8000 [Depreciation] CurlHttpClient should implement method HttpClientInterface::withOptions(array $options) · Issue #40893 · symfony/symfony · GitHub
[go: up one dir, main page]
Skip to content

[Depreciation] CurlHttpClient should implement method HttpClientInterface::withOptions(array $options) #40893

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
bastien70 opened this issue Apr 21, 2021 · 3 comments
Closed

[Depreciation] CurlHttpClient should implement method HttpClientInterface::withOptions(array $options) #40893

bastien70 opened this issue Apr 21, 2021 · 3 comments
Labels
Bug HttpClient Status: Needs Review

Comments

@bastien70
Copy link

Symfony version(s) affected: 5.2.6

Description
On all my pages, I now have the following depreciation:

Class "Symfony\Component\HttpClient\CurlHttpClient" should implement method "Symfony\Contracts\HttpClient\HttpClientInterface::withOptions(array $options)": Returns a new instance of the client with new default options.

image

It seems to come from vendor 'symfony/error-handler/DebugClassLoader.php", line 357

Is it going to be fixed?
@bastien70 bastien70 added the Bug label Apr 21, 2021
@nicolas-grekas
Copy link
Member

Yes, this is fixed in 5.3, due in 6 weeks.

@lostfocus
Copy link
Contributor

Happens in 4.4, too.

@spipu
Copy link
spipu commented Apr 28, 2021 •
edited
Loading

and also in the TraceableHttpClient too in 4.4

1x: Class "Symfony\Component\HttpClient\TraceableHttpClient" should implement method "Symfony\Contracts\HttpClient\HttpClientInterface::withOptions(array $options)": Returns a new instance of the client with new default options

@spipu spipu mentioned this issue Apr 28, 2021
Closed
@lyrixx lyrixx mentioned this issue Apr 30, 2021
Closed
@nicolas-grekas nicolas-grekas mentioned this issue May 2, 2021
Merged
derrabus added a commit that referenced this issue May 3, 2021
@derrabus
bug #41075 [ErrorHandler] Skip "same vendor" @method deprecations…
88dcf52 
… for `Symfony\*` classes unless symfony/symfony is being tested (nicolas-grekas)

This PR was merged into the 4.4 branch.

Discussion
----------

[ErrorHandler] Skip "same vendor" ``@method`` deprecations for `Symfony\*` classes unless symfony/symfony is being tested

| Q             | A
| ------------- | ---
| Branch?       | 4.4
| Bug fix?      | yes
| New feature?  | no
| Deprecations? | no
| Tickets       | ref #40975 #40996 #40893
| License       | MIT
| Doc PR        |

Replaces #41001

Commits
-------

7a1a910 [ErrorHandler] Skip "same vendor" ``@method`` deprecations for `Symfony\*` classes unless symfony/symfony is being tested
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
Bug HttpClient Status: Needs Review
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
6 participants
@lostfocus @nicolas-grekas @derrabus @spipu @carsonbot @bastien70
0