[Security] Add missing French translations for logging throttling #40889
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
| Q | A |
|---|---|
| Branch? | 5.2 |
| Bug fix? | no |
| New feature? | no |
| Deprecations? | no |
| Tickets | Fix #40863 (at least for French) |
| License | MIT |
| Doc PR | N/A |
* 5.1: Changed private static array-properties to const static properties newly introduced in 5.1
static properties newly introduced in 5.2
…simonberger) This PR was merged into the 5.2 branch. Discussion ---------- Changed private static array-properties to const (5.2) | Q | A | ------------- | --- | Branch? | 5.2 | Bug fix? | no | New feature? | no | Deprecations? | no | License | MIT This continues #39959 for 5.2 Just two array-properties and a string property in one class newly added. /cc @nicolas-grekas Commits ------- a5fd0c4 Changed private static array-properties to const static properties newly introduced in 5.2
This PR was merged into the 5.1 branch. Discussion ---------- Fix typo in test | Q | A | ------------- | --- | Branch? | 5.1 | Bug fix? | no | New feature? | no | Deprecations? | no | Tickets | --- | License | MIT | Doc PR | --- Commits ------- 79c9a1a Fix typo in test
* 5.1: Fix typo in test
… constraints (xabbuh) This PR was merged into the 5.1 branch. Discussion ---------- [Validator] propagate the object being validated to nested constraints | Q | A | ------------- | --- | Branch? | 5.1 | Bug fix? | yes | New feature? | no | Deprecations? | no | Tickets | Fix #39145 | License | MIT | Doc PR | Commits ------- 8c1bac9 propagate the object being validated to sub-constraints
…yPointsPass (chalasr) This PR was merged into the 5.2 branch. Discussion ---------- [SecurityBundle] Fix referencing aliases from RegisterEntryPointsPass | Q | A | ------------- | --- | Branch? | 5.2 | Bug fix? | yes | New feature? | no | Deprecations? | no | Tickets | #39881 | License | MIT | Doc PR | - Resolving child definitions' classes in this pass unlocks registering it as `TYPE_BEFORE_OPTIMIZATION`, and get rid of the issue reported in #39881. The parent class resolution logic was borrowed from an existing pass (RegisterEventListenersAndSubscribersPass), that makes it the best solution I can think of. Commits ------- 8dcc3d6 [SecurityBundle] Fix referencing aliases from RegisterEntryPointPass
* 4.4: Fix transient tests Fix class resolution in Doctrine EventListenerPass [Serializer] Fix tests marked as incomplete [Translator] fix handling plural for floating numbers fix redis messenger options with dsn Update ConsoleEvents.php allow Doctrine persistence 2 too [Messenger] Fix transporting non-UTF8 payloads by encoding them using base 64 add doctrine/persistence as a dev requirement Exclude non-initialized properties accessed with getters
* 5.1: Fix transient tests Fix class resolution in Doctrine EventListenerPass [Serializer] Fix tests marked as incomplete propagate the object being validated to sub-constraints [Translator] fix handling plural for floating numbers fix redis messenger options with dsn Update ConsoleEvents.php allow Doctrine persistence 2 too [Messenger] Fix transporting non-UTF8 payloads by encoding them using base 64 add doctrine/persistence as a dev requirement Exclude non-initialized properties accessed with getters
* 4.4: Use createMock() and use import instead of FQCN
* 5.1: Use createMock() and use import instead of FQCN
This PR was merged into the 5.1 branch. Discussion ---------- [FrameworkBundle] add missing use statement | Q | A | ------------- | --- | Branch? | 5.1 | Bug fix? | no | New feature? | no | Deprecations? | no | Tickets | | License | MIT | Doc PR | Commits ------- cfab105 add missing use statement
* 5.1: add missing use statement
* 5.1: Fix merge
* 5.1: Fix merge
* 5.1: More cleanups and fixes
This PR was merged into the 5.1 branch. Discussion ---------- Use import instead of FQCN | Q | A | ------------- | --- | Branch? | 5.1 | Bug fix? | no | New feature? | no | Deprecations? | no | Tickets | --- | License | MIT | Doc PR | --- Commits ------- b2fee7a Use import instead of FQCN
* 5.1: Use import instead of FQCN
…e service is private
…Noop when the service is private (fancyweb) This PR was merged into the 5.2 branch. Discussion ---------- [DependencyInjection] [AliasDeprecatedPublicServicesPass] Noop when the service is private | Q | A | ------------- | --- | Branch? | 5.2 | Bug fix? | yes | New feature? | no | Deprecations? | no | Tickets | - | License | MIT | Doc PR | - If the service is already private, I think we can just ignore the tag and do nothing. Moreover, when we deprecate a public service, if an user already sets its definition to private, it will be transparent instead of throwing. Commits ------- 00048a9 [DependencyInjection][AliasDeprecatedPublicServicesPass] Noop when the service is private
| @@ -70,6 +70,14 @@ | |||
| <source>Invalid or expired login link.</source> | |||
| <target>Invalid or expired login link.</target> | |||
| </trans-unit> | |||
| <trans-unit id="19"> | |||
There was a problem hiding this comment.
If the only difference between the two message is the singular/plural "minutes" ... shouldn't we use the pluralization feature of translation messages?
There was a problem hiding this comment.
I think the error message comes from here: https://github.com/symfony/symfony/blob/v5.3.0-BETA1/src/Symfony/Component/Security/Core/Exception/TooManyLoginAttemptsAuthenticationException.php#L44
So maybe it would require updating the Exception first.
There was a problem hiding this comment.
Yes, we should fix the message key. See my
8000
comment on the issue.
derrabus
requested changes
Apr 21, 2021
|
Sorry for the confusion. We will leave the message keys as they are. Nevertheless, please target the 4.4 branch. |
|
As this PR was automatically closed somehow (maybe by the force-push, I'm not sure) I opened #41003 that targets 4.4 branch as asked. |
fabpot
added a commit
that referenced
this pull request
May 1, 2021
…hrottling (jmsche) This PR was merged into the 4.4 branch. Discussion ---------- [Security] Add missing French translations for logging throttling | Q | A | ------------- | --- | Branch? | 4.4 | Bug fix? | no | New feature? | no | Deprecations? | no | Tickets | Fix #40863 (at least for French) | License | MIT | Doc PR | N/A Note: this PR replaces #40889 as somehow force-push closed the other PR. Also this one targets 4.4 branch directly :) Commits ------- b64efd2 [Security] Add missing French translations for logging throttling
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.