8000 [FrameworkBundle] add missing use statement by xabbuh · Pull Request #39994 · symfony/symfony · GitHub
[go: up one dir, main page]
Skip to content

[FrameworkBundle] add missing use statement #39994

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jan 27, 2021
Merged

[FrameworkBundle] add missing use statement #39994

merged 1 commit into from
Jan 27, 2021

Conversation

xabbuh
Copy link
Member
@xabbuh xabbuh commented Jan 27, 2021 •
edited
Loading
Q A
Branch? 5.1
Bug fix? no
New feature? no
Deprecations? no
Tickets
License MIT
Doc PR

@carsonbot carsonbot added this to the 5.1 milestone Jan 27, 2021
@carsonbot
Copy link

Hey!

Excellent, just like I would have done it.

But you have made this PR towards a branch that is not maintained anymore. :/
Could you update the PR base branch to target one of these branches instead? 4.4, 5.2.

Cheers!

Carsonbot

@xabbuh xabbuh changed the title add missing use statement [FrameworkBundle] add missing use statement Jan 27, 2021
@nicolas-grekas
Copy link
Member

Thank you @xabbuh.

@nicolas-grekas nicolas-grekas merged commit fcf07ae into symfony:5.1 Jan 27, 2021
@xabbuh xabbuh deleted the pr-39968 branch January 27, 2021 10:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
FrameworkBundle Status: Needs Review
Projects
None yet
Milestone
5.1
Development

Successfully merging this pull request may close these issues.
3 participants
@xabbuh @carsonbot @nicolas-grekas
0