Changing ZulipTransportFactory tag to prevent the exception UnsupportedSchemeException #40375
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This PR was squashed before being merged into the 5.3-dev branch. Discussion ---------- [Notifier] Change Dsn api | Q | A | ------------- | --- | Branch? | 5.x, BC BREAK, but experimental | Bug fix? | yes | New feature? | yes | Deprecations? | no | Tickets | Fix symfony#39533 | License | MIT | Doc PR | --- This PR * [x] adds a new `getOptions()` method, which could be helpful and also improves testability instead of dealing with reflections * [x] makes the `__construct()` method accept only a dsn as string * [x] removes `fromString()` method * [x] afterwards you can always rely on `getOriginalDsn()` method, like described by its return type, before it returned null when Dsn class was instantiated via the constructor and a `TypeError` was thrown * [x] refactored the tests This should be done for the Mailer Dsn class too, but this class is not experimental anymore... 🤔 Commits ------- 44e8ca1 [Notifier] Change Dsn api
This PR was merged into the 5.3-dev branch. Discussion ---------- No patch version in CHANGELOG | Q | A | ------------- | --- | Branch? | 5.x | Bug fix? | no | New feature? | no | Deprecations? | no | Tickets | --- | License | MIT | Doc PR | --- Based on symfony/symfony-docs#14830 cc @fabpot, feel free to close, as we discussed this already via Slack Commits ------- 575d9b0 No patch version in CHANGELOG
…Longo) This PR was merged into the 5.3-dev branch. Discussion ---------- [Notifier] Add GatewayApi bridge | Q | A | ------------- | --- | Branch? | 5.x | Bug fix? | no | New feature? | yes | Deprecations? | no | Tickets | Replaces symfony#38685 | License | MIT | Doc PR | symfony/symfony-docs#14463 | Recipe PR | symfony/recipes#864 Initial PR by @PGLongo Commits ------- 6b9f721 [Notifier] Add GatewayApi bridge
…elienheyliot) This PR was merged into the 5.3-dev branch. Discussion ---------- [Notifier] Add Octopush notifier transport | Q | A | ------------- | --- | Branch? | 5.x | Bug fix? | no | New feature? | yes <!-- please update src/**/CHANGELOG.md files --> | Deprecations? | no | License | MIT | Doc PR | symfony/symfony-docs#14779 <!-- required for new features --> | Recipe PR| symfony/recipes#870 Commits ------- 93dde15 Add Octopush notifier transport
This PR was squashed before being merged into the 5.3-dev branch. Discussion ---------- [Notifier] Add AllMySms Bridge | Q | A | ------------- | --- | Branch? | 5.x | Bug fix? | no | New feature? | yes | Deprecations? | no | License | MIT | Doc PR | symfony/symfony-docs#14739 | Recipe | symfony/recipes#865 Add AllMySms bridge to Symfony Notifier Commits ------- 4a71c36 [Notifier] Add AllMySms Bridge
* 5.2: µCS fix CS fix CS fix [travis] use PHP 8.0 to patch return types and run deps=low Add me as a Notifier code owner Update sl_SI translations Don't trigger deprecation for deprecated aliases pointing to deprecated definitions [HttpFoundation] use atomic writes in MockFileSessionStorage fix typo Make EmailMessage & SmsMessage transport nullable remove unused argument [SecurityBundle] Drop dead check [DI] fix param annotation [SecurityBundle] Remove invalid service definition [Config] Add \Symfony\Component\Config\Loader::load() return type Simplify PHP CS Fixer config Rename normalize param
* 5.2: [DI] fix merge
* 5.2: [travis] always install ext-mongodb Fix circular loop with EntityManager
* 5.2: [VarDumper] Fix tests
…skarStark) This PR was merged into the 5.3-dev branch. Discussion ---------- [Notifier] [Octopush] Use the correct provider | Q | A | ------------- | --- | Branch? | 5.x | Bug fix? | no | New feature? | no | Deprecations? | no | Tickets | --- | License | MIT | Doc PR | --- Follows symfony#39702 Commits ------- 9ecef3b [Notifier] [Octopush] Use the correct provider
* 5.2: [Notifier] [GoogleChat] Fix wrong test
…ad_key + set parameter via ctor
…dKey parameter to thread_key + set parameter via ctor (OskarStark) This PR was squashed before being merged into the 5.3-dev branch. Discussion ---------- [Notifier] [GoogleChat] [BC BREAK] Rename threadKey parameter to thread_key + set parameter via ctor | Q | A | ------------- | --- | Branch? | 5.x, but BC BREAK for experimental bridge | Bug fix? | no | New feature? | no | Deprecations? | no | Tickets | --- | License | MIT | Doc PR | symfony/symfony-docs#14834 | Recipe | symfony/recipes#871 All bridges receive their options via the `constructor` and use snake_case parameters. ### Todos * [x] Update recipe * [x] Update documentation cc @GromNaN as you provided the bridge Commits ------- 5a71928 [Notifier] [GoogleChat] [BC BREAK] Rename threadKey parameter to thread_key + set parameter via ctor
This PR was merged into the 5.3-dev branch. Discussion ---------- [Notifier] Fix underline | Q | A | ------------- | --- | Branch? | 5.x | Bug fix? | no | New feature? | no | Deprecations? | no | Tickets | --- | License | MIT | Doc PR | --- Commits ------- 38f6331 Fix underline
…uteBag class (xabbuh) This PR was merged into the 5.3-dev branch. Discussion ---------- [HttpFoundation] deprecate the NamespacedAttributeBag class | Q | A | ------------- | --- | Branch? | 5.x | Bug fix? | no | New feature? | no | Deprecations? | yes | Tickets | Fix symfony#32616 | License | MIT | Doc PR | Commits ------- da9de69 deprecate the NamespacedAttributeBag class
…y of roles (lyrixx) This PR was merged into the 5.3-dev branch. Discussion ---------- [Security] RoleHierarchy returns an unique array of roles | Q | A | ------------- | --- | Branch? | 5.x | Bug fix? | no | New feature? | yes: performance | Deprecations? | | Tickets | | License | MIT | Doc PR | Speedup: https://github.com/symfony/symfony/blob/5.x/src/Symfony/Component/Security/Core/Authorization/Voter/RoleVoter.php#L48 BTW, why isn't an `in_array()` there? Commits ------- aa0494c [Security] RoleHierarchy returns unique an unique array of roles
…ng the appropriate HTTP status code (dunglas) This PR was squashed before being merged into the 5.3-dev branch. Discussion ---------- [FrameworkBundle] Add renderForm() helper setting the appropriate HTTP status code | Q | A | ------------- | --- | Branch? | 5.x | Bug fix? | no | New feature? | yes <!-- please update src/**/CHANGELOG.md files --> | Deprecations? | no <!-- please update UPGRADE-*.md and src/**/CHANGELOG.md files --> | Tickets | n/a | License | MIT | Doc PR | todo A 422 HTTP status code should be returned after the submission of an invalid form. Some libraries including [Turbo](hotwired/turbo#39) rely on this behavior and will not display the updated form (containing errors) unless this status code is present. Rails also [recently switched to this behavior ](rails/rails#41026) by default for the same reason. I propose to introduce a new helper method rendering the form and setting the appropriate status code. It makes the code cleaner: ```php // src/Controller/TaskController.php // ... use Symfony\Component\HttpFoundation\Request; class TaskController extends AbstractController { public function new(Request $request): Response { $task = new Task(); $form = $this->createForm(TaskType::class, $task); $form->handleRequest($request); if ($form->isSubmitted() && $form->isValid()) { $task = $form->getData(); // ... return $this->redirectToRoute('task_success'); } return $this->renderForm('task/new.html.twig', $form); } } ``` Commits ------- 4c77e50 [FrameworkBundle] Add renderForm() helper setting the appropriate HTTP status code
* 5.2: [Security] Replace message data in JSON security error response [Security] Replace message data in JSON security error response [DI] Skip deprecated definitions in CheckTypeDeclarationsPass [Messenger][AmazonSqs] Fix auto-setup for fifo queue [DoctrineBridge] Take into account that indexBy="person_id" could be a db column name, for a referenced entity
* 5.2: fix merge
…ndle standalone tests in deps=high (wouterj) This PR was merged into the 5.3-dev branch. Discussion ---------- [FrameworkBundle] Disable lock to fix FrameworkBundle standalone tests in deps=high | Q | A | ------------- | --- | Branch? | 5.x | Bug fix? | no | New feature? | no | Deprecations? | no | Tickets | - | License | MIT | Doc PR | - Commits ------- b169ef9 [FrameworkBundle] Explicitly disable lock to fix FrameworkBundle standalone tests
* 5.2: [Messenger][SQS] Document missing option Specify that we run CI on Ubuntu-20.04 zero parts can be omitted in date interval input
….interval` (in `security.firewalls`) option to change the default throttling interval. (damienfa, wouterj) This PR was merged into the 5.3-dev branch. Discussion ---------- [RateLimiter][Security] Add a `login_throttling.interval` (in `security.firewalls`) option to change the default throttling interval. | Q | A | ------------- | --- | Branch | 5.x | Bug fix | no | New feature | yes | Deprecations | no | License | MIT | Doc PR |⚠️ no doc The only way to customize the default rate-limiter's options of the login_throttling (means fixed_window / 1 minute / 5 tokens) are through a custom limiter, which implies to declare a rate-limiter factory in the "framework.rate_limiter", a service which use this factory etc. It's really heavy just for changing an interval (moreover, 1 minute can be discutable). In this PullRequest, I just propose to allow an `interval` option. Example : ```yaml security: firewalls: main: login_throttling: max_attempts: 5 interval: '15 minutes' ``` See functional tests. 🤷🏻♂️ This pull-request is a copy of [this pull-request ](symfony#39927) that I've created some weeks ago. On the original PR, I just needed to rebase on 5.x to pass the tests (fabbot etc.) but the rebase I've tried runs in a loop of conflicts and I'm stuck. I've never experienced this before... SORRY. Commits ------- d1a0342 Fix tests cc74095 changes rebased
…(jrushlow) This PR was merged into the 5.3-dev branch. Discussion ---------- [TwigBridge][TwigBundle] Twig serialize filter | Q | A | ------------- | --- | Branch? | 5.x | Bug fix? | no | New feature? | yes | Deprecations? | no | Tickets | Fix symfony#40227 | License | MIT | Doc PR | symfony/symfony-docs#15039 Adds a new `serialize` filter for Twig utilizing the Serializer component. As suggested in symfony#40227 - would allow you to pass a serialized object to the front end without needing to make an ajax call. Commits ------- abb534a implement twig serialize filter
…tations:1.13 || 2.0 (Nyholm) This PR was squashed before being merged into the 5.3-dev branch. Discussion ---------- [FrameworkBundle] Add support for doctrine/annotations:1.13 || 2.0 | Q | A | ------------- | --- | Branch? | 5.x | Bug fix? | no | New feature? | yes | Deprecations? | yes | Tickets | | License | MIT | Doc PR | This PR will deprecate passing any other values that "none", "php_array" and "file" to `framework.annotation.cache`. It will also support `doctrine/annotations:^1.13 || ^2.0`. It will use the PSR-6 cache if possible. Commits ------- 91e844b [FrameworkBundle] Add support for doctrine/annotations:1.13 || 2.0
* 5.2: [Validator] Fix return types Add translation for Belarusian fix parsing calls of methods named "method" [Security] Remove unnecessary inherited doc annotation deal with indented heredoc/nowdoc tokens Adding templates for Belarusian
* 5.2: [Messenger] Doctrine setup with migrations
…eclarations (chalasr) This PR was merged into the 5.3-dev branch. Discussion ---------- [Security] Re-add accidentally removed property declarations | Q | A | ------------- | --- | Branch? | 5.x | Bug fix? | no | New feature? | no | Deprecations? | no | Tickets | - | License | MIT | Doc PR | - spotted while playing with psalm locally, mistake made in symfony#39802 Commits ------- bccf736 [Security] Readd accidentally removed property declarations
Changing ZulipTransportFactory to 'chatter.transport_factory' to prevent the exception UnsupportedSchemeException "The "zulip" scheme is not supported." Fixing symfony#40374
|
Hey! I see that this is your first PR. That is great! Welcome! Symfony has a contribution guide which I suggest you to read. In short:
Review the GitHub status checks of your pull request and try to solve the reported issues. If some tests are failing, try to see if they are failing because of this change. When two Symfony core team members approve this change, it will be merged and you will become an official Symfony contributor! I am going to sit back now and wait for the reviews. Cheers! Carsonbot |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changing ZulipTransportFactory to 'chatter.transport_factory' to prevent the exception UnsupportedSchemeException "The "zulip" scheme is not supported."