No patch version in CHANGELOG #39824
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Nyholm
approved these changes
Jan 14, 2021
There was a problem hiding this comment.
This PR is following symfony/symfony-docs#14830
There are other new rules in 14830 too. But I dont think we should change all the existing change logs, right?
Im happy with just changing the titles.
|
Let's merge this one, but PLEASE, no more changes to the existing CHANGELOG files. I WILL reject them :) |
|
Thank you @OskarStark. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Based on symfony/symfony-docs#14830
cc @fabpot, feel free to close, as we discussed this already via Slack