8000 Extracted OptionsResolver component out of Form by webmozart · Pull Request #3968 · symfony/symfony · GitHub
[go: up one dir, main page]
Skip to content

Extracted OptionsResolver component out of Form #3968

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 12 commits into from
May 15, 2012
Merged

Extracted OptionsResolver component out of Form #3968

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
12 commits
Select commit Hold shift + click to select a range
b9d053e
[Form] Moved Options classes to new OptionsParser component
webmozart Apr 17, 2012
04522ca
[OptionsParser] Added method replaceDefaults()
webmozart Apr 23, 2012
256b708
[OptionsParser] Renamed OptionsParser to OptionsResolver
webmozart May 10, 2012
95454f5
[OptionsResolver] Fixed typos
webmozart May 10, 2012
876fd9b
[OptionsResolver] Implemented fluid interface
webmozart May 11, 2012
9c76750
[OptionsResolver] Fixed doc and block nesting
webmozart May 11, 2012
6ce68b1
[OptionsResolver] Removed reference to non-existing property
webmozart May 11, 2012
16f7d20
[OptionsResolver] Improved implementation and clarity of the Options …
webmozart May 11, 2012
2b46975
[OptionsResolver] Fixed Options::replace() method
webmozart May 11, 2012
d60626e
[OptionsResolver] Fixed clear() and remove() method in Options class
webmozart May 14, 2012
1c5f6c7
[OptionsResolver] Fixed issues mentioned in the PR comments
webmozart May 14, 2012
95727ff
[OptionsResolver] Updated PHP requirements to 5.3.3
webmozart May 15, 2012
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
[OptionsResolver] Fixed typos
  • Loading branch information
@webmozart
webmozart committed May 14, 2012
commit 95454f5f6b7a3c929cdb6ff8c838f3f436d281ac
25 changes: 13 additions & 12 deletions src/Symfony/Component/OptionsResolver/OptionsResolver.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -57,12 +57,12 @@ public function __construct()
/**
* Sets default option values.
*
* @param array $options A list of option names as keys and default values
* as values. The option values may be closures
* of the following signatures:
* @param array $defaultValues A list of option names as keys and default values
* as values. The option values may be closures
* of the following signatures:
*
* - function (Options $options)
* - function (Options $options, $previousValue)
* - function (Options $options)
* - function (Options $options, $previousValue)
*/
public function setDefaults(array $defaultValues)
{
Expand All @@ -80,11 +80,11 @@ public function setDefaults(array $defaultValues)
* performance if the previous default value is calculated by an expensive
* closure.
*
* @param array $options A list of option names as keys and default values
* as values. The option values may be closures
* of the following signature:
* @param array $defaultValues A list of option names as keys and default values
* as values. The option values may be closures
* of the following signature:
*
* - function (Options $options)
* - function (Options $options)
*/
public function replaceDefaults(array $defaultValues)
{
Expand Down Expand Up @@ -214,10 +214,11 @@ public function resolve(array $options)
* Validates that the given option names exist and throws an exception
* otherwise.
*
* @param array $optionNames A list of option names.
* @param array $optionNames A list of option names.
*
* @throws InvalidOptionsException If any of the options has not been
* defined.
* @throws InvalidOptionsException If any of the options has not been
* defined.
* @throws MissingOptionsException If a required option is missing.
*/
private function validateOptionNames(array $optionNames)
{
Expand Down
4 changes: 2 additions & 2 deletions src/Symfony/Component/OptionsResolver/README.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -22,7 +22,7 @@ possible, and may only be one of "male" and "female".
public function __construct(array $options = array())
{
$resolver = new OptionsResolver();
$this->configureOptions($resolver);
$this->configure($resolver);

$this->options = $resolver->resolve($options);
}
Expand Down Expand Up @@ -53,7 +53,7 @@ possible, and may only be one of "male" and "female".

We can now easily instantiate a Person object:

// 'gender' is implicitely set to 'female'
// 'gender' is implicitly set to 'female'
$person = new Person(array(
'firstName' => 'Jane',
'lastName' => 'Doe',
Expand Down
5 changes: 4 additions & 1 deletion src/Symfony/Component/OptionsResolver/Tests/OptionResolverTest.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -16,7 +16,10 @@

class OptionsResolverTest extends \PHPUnit_Framework_TestCase
{
private $options;
/**
* @var OptionsResolver
*/
private $resolver;

protected function setUp()
{
Expand Down
0