[OptionsParser] Renamed OptionsParser to OptionsResolver

symfony · fabpot · May 15, 2012 · Apr 17, 2012 · Apr 23, 2012 · May 10, 2012
commit 256b7081a423caeb404c9ec838b6ee21cc7e5bab
diff --git a/composer.json b/composer.json
@@ -42,7 +42,7 @@
         "symfony/http-foundation": "self.version",
         "symfony/http-kernel": "self.version",
         "symfony/locale": "self.version",
-        "symfony/options-parser": "self.version",
+        "symfony/options-resolver": "self.version",
         "symfony/process": "self.version",
         "symfony/routing": "self.version",
         "symfony/security": "self.version",

diff --git a/src/Symfony/Bridge/Doctrine/Form/Type/DoctrineType.php b/src/Symfony/Bridge/Doctrine/Form/Type/DoctrineType.php
@@ -19,7 +19,7 @@
 use Symfony\Bridge\Doctrine\Form\EventListener\MergeDoctrineCollectionListener;
 use Symfony\Bridge\Doctrine\Form\DataTransformer\CollectionToArrayTransformer;
 use Symfony\Component\Form\AbstractType;
-use Symfony\Component\OptionsParser\Options;
+use Symfony\Component\OptionsResolver\Options;
 
 abstract class DoctrineType extends AbstractType
 {

diff --git a/src/Symfony/Bridge/Propel1/Form/Type/ModelType.php b/src/Symfony/Bridge/Propel1/Form/Type/ModelType.php
@@ -15,7 +15,7 @@
 use Symfony\Bridge\Propel1\Form\DataTransformer\CollectionToArrayTransformer;
 use Symfony\Component\Form\AbstractType;
 use Symfony\Component\Form\FormBuilder;
-use Symfony\Component\OptionsParser\Options;
+use Symfony\Component\OptionsResolver\Options;
 
 /**
  * ModelType class.

diff --git a/src/Symfony/Component/Form/Extension/Core/Type/ChoiceType.php b/src/Symfony/Component/Form/Extension/Core/Type/ChoiceType.php
@@ -26,7 +26,7 @@
 use Symfony\Component\Form\Extension\Core\DataTransformer\ChoiceToBooleanArrayTransformer;
 use Symfony\Component\Form\Extension\Core\DataTransformer\ChoicesToValuesTransformer;
 use Symfony\Component\Form\Extension\Core\DataTransformer\ChoicesToBooleanArrayTransformer;
-use Symfony\Component\OptionsParser\Options;
+use Symfony\Component\OptionsResolver\Options;
 
 class ChoiceType extends AbstractType
 {

diff --git a/src/Symfony/Component/Form/Extension/Core/Type/DateTimeType.php b/src/Symfony/Component/Form/Extension/Core/Type/DateTimeType.php
@@ -21,7 +21,7 @@
 use Symfony\Component\Form\Extension\Core\DataTransformer\DateTimeToStringTransformer;
 use Symfony\Component\Form\Extension\Core\DataTransformer\DateTimeToTimestampTransformer;
 use Symfony\Component\Form\Extension\Core\DataTransformer\ArrayToPartsTransformer;
-use Symfony\Component\OptionsParser\Options;
+use Symfony\Component\OptionsResolver\Options;
 
 class DateTimeType extends AbstractType
 {

diff --git a/src/Symfony/Component/Form/Extension/Core/Type/DateType.php b/src/Symfony/Component/Form/Extension/Core/Type/DateType.php
@@ -22,7 +22,7 @@
 use Symfony\Component\Form\Extension\Core\DataTransformer\DateTimeToStringTransformer;
 use Symfony\Component\Form\Extension\Core\DataTransformer\DateTimeToTimestampTransformer;
 use Symfony\Component\Form\ReversedTransformer;
-use Symfony\Component\OptionsParser\Options;
+use Symfony\Component\OptionsResolver\Options;
 
 class DateType extends AbstractType
 {

diff --git a/src/Symfony/Component/Form/Extension/Core/Type/FormType.php b/src/Symfony/Component/Form/Extension/Core/Type/FormType.php
@@ -22,7 +22,7 @@
 use Symfony\Component\Form\Extension\Core\DataMapper\PropertyPathMapper;
 use Symfony\Component\EventDispatcher\EventDispatcher;
 use Symfony\Component\Form\Exception\FormException;
-use Symfony\Component\OptionsParser\Options;
+use Symfony\Component\OptionsResolver\Options;
 
 class FormType extends AbstractType
 {

diff --git a/src/Symfony/Component/Form/Extension/Core/Type/TimeType.php b/src/Symfony/Component/Form/Extension/Core/Type/TimeType.php
@@ -20,7 +20,7 @@
 use Symfony\Component\Form\Extension\Core\DataTransformer\DateTimeToTimestampTransformer;
 use Symfony\Component\Form\Extension\Core\DataTransformer\DateTimeToArrayTransformer;
 use Symfony\Component\Form\FormView;
-use Symfony\Component\OptionsParser\Options;
+use Symfony\Component\OptionsResolver\Options;
 
 class TimeType extends AbstractType
 {

diff --git a/src/Symfony/Component/Form/Extension/Core/Type/TimezoneType.php b/src/Symfony/Component/Form/Extension/Core/Type/TimezoneType.php
@@ -13,7 +13,7 @@
 
 use Symfony\Component\Form\AbstractType;
 use Symfony\Component\Form\Extension\Core\ChoiceList\ChoiceList;
-use Symfony\Component\OptionsParser\Options;
+use Symfony\Component\OptionsResolver\Options;
 
 class TimezoneType extends AbstractType
 {

diff --git a/src/Symfony/Component/Form/FormFactory.php b/src/Symfony/Component/Form/FormFactory.php
@@ -14,7 +14,7 @@
 use Symfony\Component\Form\Exception\FormException;
 use Symfony\Component\Form\Exception\UnexpectedTypeException;
 use Symfony\Component\Form\Exception\TypeDefinitionException;
-use Symfony\Component\OptionsParser\OptionsParser;
+use Symfony\Component\OptionsResolver\OptionsResolver;
 
 class FormFactory implements FormFactoryInterface
 {
@@ -221,7 +221,7 @@ public function createNamedBuilder($type, $name, $data = null, array $options =
         $types = array();
         $optionValues = array();
         $knownOptions = array();
-        $optionsParser = new OptionsParser();
+        $optionsResolv
10000
er = new OptionsResolver();
 
         // Bottom-up determination of the type hierarchy
         // Start with the actual type and look for the parent type
@@ -255,14 +255,14 @@ public function createNamedBuilder($type, $name, $data = null, array $options =
             // options. Default options of children override default options
             // of parents.
             $typeOptions = $type->getDefaultOptions();
-            $optionsParser->setDefaults($typeOptions);
-            $optionsParser->addAllowedValues($type->getAllowedOptionValues());
+            $optionsResolver->setDefaults($typeOptions);
+            $optionsResolver->addAllowedValues($type->getAllowedOptionValues());
             $knownOptions = array_merge($knownOptions, array_keys($typeOptions));
 
             foreach ($type->getExtensions() as $typeExtension) {
                 $extensionOptions = $typeExtension->getDefaultOptions();
-                $optionsParser->setDefaults($extensionOptions);
-                $optionsParser->addAllowedValues($typeExtension->getAllowedOptionValues());
+                $optionsResolver->setDefaults($extensionOptions);
+                $optionsResolver->addAllowedValues($typeExtension->getAllowedOptionValues());
                 $knownOptions = array_merge($knownOptions, array_keys($extensionOptions));
             }
         }
@@ -278,7 +278,7 @@ public function createNamedBuilder($type, $name, $data = null, array $options =
         }
 
         // Resolve options
-        $options = $optionsParser->parse($options);
+        $options = $optionsResolver->resolve($options);
 
         for ($i = 0, $l = count($types); $i < $l && !$builder; ++$i) {
             $builder = $types[$i]->createBuilder($name, $this, $options);

diff --git a/src/Symfony/Component/Form/Tests/Extension/Core/Type/DateTypeTest.php b/src/Symfony/Component/Form/Tests/Extension/Core/Type/DateTypeTest.php
@@ -23,7 +23,7 @@ protected function setUp()
     }
 
     /**
-     * @expectedException Symfony\Component\OptionsParser\Exception\InvalidOptionsException
+     * @expectedException Symfony\Component\OptionsResolver\Exception\InvalidOptionsException
      */
     public function testInvalidWidgetOption()
     {
@@ -33,7 +33,7 @@ public function testInvalidWidgetOption()
     }
 
     /**
-     * @expectedException Symfony\Component\OptionsParser\Exception\InvalidOptionsException
+     * @expectedException Symfony\Component\OptionsResolver\Exception\InvalidOptionsException
      */
     public function testInvalidInputOption()
     {

diff --git a/src/Symfony/Component/Form/Tests/FormFactoryTest.php b/src/Symfony/Component/Form/Tests/FormFactoryTest.php
@@ -279,7 +279,7 @@ public function testCreateNamedBuilderExpectsBuilderToBeReturned()
     }
 
     /**
-     * @expectedException Symfony\Component\OptionsParser\Exception\InvalidOptionsException
+     * @expectedException Symfony\Component\OptionsResolver\Exception\InvalidOptionsException
      */
     public function testCreateNamedBuilderExpectsOptionsToExist()
     {
@@ -292,7 +292,7 @@ public function testCreateNamedBuilderExpectsOptionsToExist()
     }
 
     /**
-     * @expectedException Symfony\Component\OptionsParser\Exception\InvalidOptionsException
+     * @expectedException Symfony\Component\OptionsResolver\Exception\InvalidOptionsException
      */
     public function testCreateNamedBuilderExpectsOptionsToBeInValidRange()
     {

diff --git a/src/Symfony/Component/Form/composer.json b/src/Symfony/Component/Form/composer.json
@@ -19,7 +19,7 @@
         "php": ">=5.3.3",
         "symfony/event-dispatcher": "2.1.*",
         "symfony/locale": "2.1.*",
-        "symfony/options-parser": "2.1.*"
+        "symfony/options-resolver": "2.1.*"
     },
     "require-dev": {
         "symfony/validator": "2.1.*",

diff --git a/...nsParser/Exception/ExceptionInterface.php → ...Resolver/Exception/ExceptionInterface.php b/...nsParser/Exception/ExceptionInterface.php → ...Resolver/Exception/ExceptionInterface.php
@@ -9,7 +9,7 @@
  * file that was distributed with this source code.
  */
 
-namespace Symfony\Component\OptionsParser\Exception;
+namespace Symfony\Component\OptionsResolver\Exception;
 
 /**
  * Marker interface for the Options component.

diff --git a/...ser/Exception/InvalidOptionsException.php → ...ver/Exception/InvalidOptionsException.php b/...ser/Exception/InvalidOptionsException.php → ...ver/Exception/InvalidOptionsException.php
@@ -9,7 +9,7 @@
  * file that was distributed with this source code.
  */
 
-namespace Symfony\Component\OptionsParser\Exception;
+namespace Symfony\Component\OptionsResolver\Exception;
 
 /**
  * Exception thrown when an invalid option is passed.

diff --git a/...ser/Exception/MissingOptionsException.php → ...ver/Exception/MissingOptionsException.php b/...ser/Exception/MissingOptionsException.php → ...ver/Exception/MissingOptionsException.php
@@ -9,7 +9,7 @@
  * file that was distributed with this source code.
  */
 
-namespace Symfony\Component\OptionsParser\Exception;
+namespace Symfony\Component\OptionsResolver\Exception;
 
 /**
  * Exception thrown when a required option is missing.

diff --git a/...r/Exception/OptionDefinitionException.php → ...r/Exception/OptionDefinitionException.php b/...r/Exception/OptionDefinitionException.php → ...r/Exception/OptionDefinitionException.php
@@ -9,7 +9,7 @@
  * file that was distributed with this source code.
  */
 
-namespace Symfony\Component\OptionsParser\Exception;
+namespace Symfony\Component\OptionsResolver\Exception;
 
 /**
  * Thrown when an option definition is invalid.

diff --git a/src/Symfony/Component/OptionsParser/LICENSE → ...Symfony/Component/OptionsResolver/LICENSE b/src/Symfony/Component/OptionsParser/LICENSE → ...Symfony/Component/OptionsResolver/LICENSE
diff --git a/...ny/Component/OptionsParser/LazyOption.php → .../Component/OptionsResolver/LazyOption.php b/...ny/Component/OptionsParser/LazyOption.php → .../Component/OptionsResolver/LazyOption.php
@@ -9,7 +9,7 @@
  * file that was distributed with this source code.
  */
 
-namespace Symfony\Component\OptionsParser;
+namespace Symfony\Component\OptionsResolver;
 
 use Closure;
 

diff --git a/...mfony/Component/OptionsParser/Options.php → ...ony/Component/OptionsResolver/Options.php b/...mfony/Component/OptionsParser/Options.php → ...ony/Component/OptionsResolver/Options.php
@@ -9,12 +9,12 @@
  * file that was distributed with this source code.
  */
 
-namespace Symfony\Component\OptionsParser;
+namespace Symfony\Component\OptionsResolver;
 
 use ArrayAccess;
 use Iterator;
 use OutOfBoundsException;
-use Symfony\Component\OptionsParser\Exception\OptionDefinitionException;
+use Symfony\Component\OptionsResolver\Exception\OptionDefinitionException;
 
 /**
  * Container for resolving inter-dependent options.

diff --git a/...Component/OptionsParser/OptionsParser.php → ...onent/OptionsResolver/OptionsResolver.php b/...Component/OptionsParser/OptionsParser.php → ...onent/OptionsResolver/OptionsResolver.php
@@ -9,18 +9,18 @@
  * file that was distributed with this source code.
  */
 
-namespace Symfony\Component\OptionsParser;
+namespace Symfony\Component\OptionsResolver;
 
-use Symfony\Component\OptionsParser\Exception\OptionDefinitionException;
-use Symfony\Component\OptionsParser\Exception\InvalidOptionsException;
-use Symfony\Component\OptionsParser\Exception\MissingOptionsException;
+use Symfony\Component\OptionsResolver\Exception\OptionDefinitionException;
+use Symfony\Component\OptionsResolver\Exception\InvalidOptionsException;
+use Symfony\Component\OptionsResolver\Exception\MissingOptionsException;
 
 /**
  * Helper for merging default and concrete option values.
  *
  * @author Bernhard Schussek <bschussek@gmail.com>
  */
-class OptionsParser
+class OptionsResolver
 {
     /**
      * The default option values.
@@ -29,13 +29,13 @@ class OptionsParser
     private $defaultOptions;
 
     /**
-     * The options known by the parser.
+     * The options known by the resolver.
      * @var array
      */
     private $knownOptions = array();
 
     /**
-     * The options required to be passed to parse().
+     * The options required to be passed to resolve().
      * @var array
      */
     private $requiredOptions = array();
@@ -100,7 +100,7 @@ public function replaceDefaults(array $defaultValues)
      *
      * This method is identical to `setDefaults`, only that no default values
      * are configured for the options. If these options are not passed to
-     * parse(), they will be missing in the final options array. This can be
+     * resolve(), they will be missing in the final options array. This can be
      * helpful if you want to determine whether an option has been set or not.
      *
      * @param  array $optionNames  A list of option names.
@@ -121,7 +121,7 @@ public function setOptional(array $optionNames)
     /**
      * Sets required options.
      *
-     * If these options are not passed to parse(), an exception will be thrown.
+     * If these options are not passed to resolve(), an exception will be thrown.
      *
      * @param  array $optionNames  A list of option names.
      *
@@ -189,7 +189,7 @@ public function addAllowedValues(array $allowedValues)
      * @throws OptionDefinitionException If a cyclic dependency is detected
      *                                   between two lazy options.
      */
-    public function parse(array $options)
+    public function resolve(array $options)
     {
         $this->validateOptionNames(array_keys($options));